archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <>
To: Kalle Valo <>
Cc: Linus Torvalds <>,,
	Arend van Spriel <>
Subject: [PATCH] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()
Date: Fri,  7 Jul 2017 13:01:33 +0100	[thread overview]
Message-ID: <> (raw)

The lower level nl80211 code in cfg80211 ensures that "len" is between
25 and NL80211_ATTR_FRAME (2304).  We subtract DOT11_MGMT_HDR_LEN (24) from
"len" so thats's max of 2280.  However, the action_frame->data[] buffer is
only BRCMF_FIL_ACTION_FRAME_SIZE (1800) bytes long so this memcpy() can

	memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],

Reported-by: "freenerguo(郭大兴)" <>
Signed-off-by: Arend van Spriel <>
Hi Kalle,

Here is the patch as Linus send it to us and I
removed the lower bound check as that is already done in cfg80211.
Now I signed off on the patch although formally I suppose Linus should
sign it off. Putting it out there so people can respond as deemed

Now fingers crossed whether patchwork will properly deal with the UTF-8
characters :-p

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d673..d182a00 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -4851,6 +4851,11 @@ static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev)
 		cfg80211_mgmt_tx_status(wdev, *cookie, buf, len, true,
 	} else if (ieee80211_is_action(mgmt->frame_control)) {
+			brcmf_err("invalid action frame length\n");
+			err = -EINVAL;
+			goto exit;
+		}
 		af_params = kzalloc(sizeof(*af_params), GFP_KERNEL);
 		if (af_params == NULL) {
 			brcmf_err("unable to allocate frame\n");

             reply	other threads:[~2017-07-07 12:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 12:01 Arend van Spriel [this message]
2017-07-07 12:47 ` [PATCH] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx() Sedat Dilek
2017-07-07 19:39   ` Arend van Spriel
2017-07-12  9:59     ` Sedat Dilek
2017-07-07 13:17 ` Johannes Berg
2017-07-07 16:37   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).