* [PATCH] rsi: fix uninitialized descriptor pointer issue
@ 2017-08-03 14:26 Amitkumar Karwar
2017-08-08 11:45 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Amitkumar Karwar @ 2017-08-03 14:26 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Amitkumar Karwar, Prameela Rani Garnepudi
From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
This patch fixes the uninitialized descriptor pointer
issue in function rsi_send_internal_mgmt_frame().
Descriptor should point to start of the skb data.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index c6e8a20..ba8a68f 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -275,6 +275,7 @@ static int rsi_send_internal_mgmt_frame(struct rsi_common *common,
rsi_dbg(ERR_ZONE, "%s: Unable to allocate skb\n", __func__);
return -ENOMEM;
}
+ desc = (struct rsi_cmd_desc *)skb->data;
desc->desc_dword0.len_qno |= cpu_to_le16(DESC_IMMEDIATE_WAKEUP);
skb->priority = MGMT_SOFT_Q;
tx_params = (struct skb_info *)&IEEE80211_SKB_CB(skb)->driver_data;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: rsi: fix uninitialized descriptor pointer issue
2017-08-03 14:26 [PATCH] rsi: fix uninitialized descriptor pointer issue Amitkumar Karwar
@ 2017-08-08 11:45 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-08-08 11:45 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: linux-wireless, Amitkumar Karwar, Prameela Rani Garnepudi
Amitkumar Karwar <amitkarwar@gmail.com> wrote:
> From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>
> This patch fixes the uninitialized descriptor pointer
> issue in function rsi_send_internal_mgmt_frame().
> Descriptor should point to start of the skb data.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Patch applied to wireless-drivers-next.git, thanks.
6345016d4bea rsi: fix uninitialized descriptor pointer issue
--
https://patchwork.kernel.org/patch/9879245/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-08 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 14:26 [PATCH] rsi: fix uninitialized descriptor pointer issue Amitkumar Karwar
2017-08-08 11:45 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).