From: Luca Coelho <luca@coelho.fi>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, Sara Sharon <sara.sharon@intel.com>
Subject: Re: [PATCH 6/6] iwlwifi: fix access to prph when transport is stopped
Date: Fri, 08 Dec 2017 14:35:19 +0200 [thread overview]
Message-ID: <1512736519.4827.287.camel@coelho.fi> (raw)
In-Reply-To: <87vahhflsf.fsf@purkki.adurom.net>
On Fri, 2017-12-08 at 14:26 +0200, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
> > Luca Coelho <luca@coelho.fi> writes:
> >
> > > On Wed, 2017-11-29 at 12:23 +0200, Kalle Valo wrote:
> > >
> > > > But no wonder I called gnus-article-fill-cited-article, the
> > > > commit
> > > > log is just weirdly wrapped. Are you using outlook or how do
> > > > you get
> > > > it so ugly? :)
> > >
> > > Heh! I don't think it's wrapped weirdly, it's just that the
> > > paragraphs
> > > don't have spaces between them, right? ;)
> >
> > Sorry, don't get what you mean with missing spaces. To me (and
> > patchwork[1] and git[2] seem to agree) the word wrapping is just
> > broken
> > for this commit log, and I have seen it also with other iwlwifi
> > commits.
> > For example, there are just two words in the second line "two
> > paths."
> >
> > The standard format for git commit logs is something like this:
> >
> > -----------------------------------------------------------------
> > -----
> > When getting HW rfkill we get stop_device being called from two
> > paths.
> > One path is the IRQ calling stop device, and updating op mode and
> > stack.
> > As a result, cfg80211 is running rfkill sync work that shuts down
> > all
> > devices (second path). In the second path, we eventually get to
> > iwl_mvm_stop_device which calls iwl_fw_dump_conf_clear-
> > >iwl_fw_dbg_stop_recording,
> > that access periphery registers.
> >
> > The device may be stopped at this point from the first path,
> > which will result with a failure to access those registers. Simply
> > checking for the trans status is insufficient, since the race will
> > still
> > exist, only minimized. Instead, move the stop from
> > iwl_fw_dump_conf_clear (which is getting called only from stop
> > path) to
> > the transport stop device function, where the access is always
> > safe.
> > This has the added value, of actually stopping dbgc before stopping
> > device even when the stop is initiated from the transport.
> > -----------------------------------------------------------------
> > -----
> >
> > [1] https://patchwork.kernel.org/patch/10074849/
>
> Instead of trying to get what I mean, check instead the patchwork
> page
> and compare there the original commit log with my reformatted
> version. I
> think that visualises pretty well what I'm trying to say :)
Okay, granted, but that's not really because of alignment or line-
wrapping. It's because the paragraphs are broken too often.
In any case, I'll pay more attention to this. So my questions remains,
do you want me to remake my pull-req to fix this?
--
Luca.
next prev parent reply other threads:[~2017-12-08 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 15:35 [PATCH 0/6] iwlwifi: fixes intended for 4.15 2017-11-25 Luca Coelho
2017-11-25 15:35 ` [PATCH 1/6] iwlwifi: mvm: set correct chains in Rx status Luca Coelho
2017-11-25 15:35 ` [PATCH 2/6] iwlwifi: mvm: don't use transmit queue hang detection when it is not possible Luca Coelho
2017-11-25 15:35 ` [PATCH 3/6] iwlwifi: mvm: fix the TX queue hang timeout for MONITOR vif type Luca Coelho
2017-11-25 15:35 ` [PATCH 4/6] iwlwifi: mvm: fix packet injection Luca Coelho
2017-11-25 15:35 ` [PATCH 5/6] iwlwifi: pcie: fix erroneous "Read failed message" Luca Coelho
2017-11-25 15:35 ` [PATCH 6/6] iwlwifi: fix access to prph when transport is stopped Luca Coelho
2017-11-29 10:19 ` Kalle Valo
2017-11-29 10:21 ` Kalle Valo
2017-11-29 10:23 ` Kalle Valo
2017-11-29 10:29 ` Luca Coelho
2017-12-08 12:22 ` Kalle Valo
2017-12-08 12:26 ` Kalle Valo
2017-12-08 12:35 ` Luca Coelho [this message]
2017-12-08 12:56 ` Kalle Valo
2017-12-08 12:28 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512736519.4827.287.camel@coelho.fi \
--to=luca@coelho.fi \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).