linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Rafal Milecki <rafal@milecki.pl>
Subject: [PATCH 5/6] brcmfmac: add new feature flags for monitor mode operation
Date: Fri, 22 Jun 2018 20:43:23 +0200	[thread overview]
Message-ID: <1529693004-20569-6-git-send-email-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <1529693004-20569-1-git-send-email-arend.vanspriel@broadcom.com>

Add two new feature flags to be used for monitor mode. One indicating
support to enable packet capture and one indicating captured packets
from firmware already include radiotap header.

Signed-off-by: Rafal Milecki <rafal@milecki.pl>
[arend: change flags and description]
Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 1 +
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index 0ee3a25..f70fec6 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -49,6 +49,7 @@ struct brcmf_feat_fwcap {
 	{ BRCMF_FEAT_MCHAN, "mchan" },
 	{ BRCMF_FEAT_P2P, "p2p" },
 	{ BRCMF_FEAT_MONITOR, "monitor" },
+	{ BRCMF_FEAT_RADIOTAP, "rtap" },
 };
 
 #ifdef DEBUG
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h
index 31a746b..31198d0 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h
@@ -33,8 +33,8 @@
  * MFP: 802.11w Management Frame Protection.
  * GSCAN: enhanced scan offload feature.
  * FWSUP: Firmware supplicant.
- * MONITOR: monitor interface
- * RADIOTAP: monitor packets include radiotap header
+ * MONITOR: firmware can pass monitor packets to host.
+ * RADIOTAP: firmware provides monitor packets including radiotap header
  */
 #define BRCMF_FEAT_LIST \
 	BRCMF_FEAT_DEF(MBSS) \
-- 
1.9.1

  parent reply	other threads:[~2018-06-22 18:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 18:43 [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Arend van Spriel
2018-06-22 18:43 ` [PATCH 1/6] brcmfmac: remove fallback mechanism for BRCMF_FEAT_MONITOR Arend van Spriel
2018-06-29  6:55   ` [1/6] " Kalle Valo
2018-06-22 18:43 ` [PATCH 2/6] brcmfmac: rename BRCMF_FEAT_MONITOR_FMT_RADIOTAP to BRCMF_FEAT_RADIOTAP Arend van Spriel
2018-06-22 18:43 ` [PATCH 3/6] brcmfmac: fix for proper support of 160MHz bandwidth Arend van Spriel
2018-06-22 18:43 ` [PATCH 4/6] brcmfmac: increase buffer for obtaining firmware capabilities Arend van Spriel
2018-06-22 18:43 ` Arend van Spriel [this message]
2018-06-22 18:43 ` [PATCH 6/6] brcmfmac: fallback mechanism to determine monitor mode features Arend van Spriel
2018-06-24 14:08   ` Rafał Miłecki
2018-06-25  8:21     ` Arend van Spriel
2018-06-24 11:48 ` [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Rafał Miłecki
2018-06-25  4:40   ` Rafał Miłecki
2018-06-25  8:31     ` Arend van Spriel
2018-06-25  8:43       ` Rafał Miłecki
2018-06-29  6:58         ` Kalle Valo
2018-08-29 20:17       ` Rafał Miłecki
2018-09-05 11:06         ` Arend van Spriel
2018-09-05 13:51           ` Rafał Miłecki
2018-06-25  8:18   ` Arend van Spriel
2018-06-25  8:43     ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529693004-20569-6-git-send-email-arend.vanspriel@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafal@milecki.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).