From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode
Date: Mon, 25 Jun 2018 10:31:24 +0200 [thread overview]
Message-ID: <5B30A85C.5080105@broadcom.com> (raw)
In-Reply-To: <CACna6rzpUDWBR_SXciEo8Z3Fsa6VZT0-KL2=WCzz9v8ww6tZVA@mail.gmail.com>
On 6/25/2018 6:40 AM, Rafał Miłecki wrote:
> On Sun, 24 Jun 2018 at 13:48, Rafał Miłecki <zajec5@gmail.com> wrote:
>> On Fri, 22 Jun 2018 at 20:45, Arend van Spriel
>> <arend.vanspriel@broadcom.com> wrote:
>>> Here a couple of patches in preparation of monitor mode support. It
>>> is mostly about querying firmware for support. While at it I stumbled
>>> upon the fact that 160MHz was not completely implemented in the driver
>>> so there is a patch for that as well.
>>>
>>> The first two patches are actually some changes to the patches that
>>> Rafal submitted. So this series depend on:
>>>
>>> [V3,2/2] brcmfmac: handle monitor mode marked msgbuf packets [1]
>>>
>>> These apply to the master branch of the wireless-drivers-next repository.
>>>
>>> [1] https://patchwork.kernel.org/patch/10474799/
>>
>> I find it pointless to submit fixes for patches that weren't accepted
>> yet. Let's work on improving original patches while they are still
>> pending.
>
> I sent V4 with changes pointed our by Arend. That obsoletes all (?)
> monitor patches from this patchset. I believe it was cleaner to
> improve original patchset (not pushed yet).
>
> My suggestion is to apply patches 3/6 and 4/6 (they aren't monitor
> related) and drop the others.
Well. Given that Kalle prefers applying "all-or-nothing" I will resubmit
the series addressing the issues you found.
Regards,
Arend
next prev parent reply other threads:[~2018-06-25 8:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 18:43 [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Arend van Spriel
2018-06-22 18:43 ` [PATCH 1/6] brcmfmac: remove fallback mechanism for BRCMF_FEAT_MONITOR Arend van Spriel
2018-06-29 6:55 ` [1/6] " Kalle Valo
2018-06-22 18:43 ` [PATCH 2/6] brcmfmac: rename BRCMF_FEAT_MONITOR_FMT_RADIOTAP to BRCMF_FEAT_RADIOTAP Arend van Spriel
2018-06-22 18:43 ` [PATCH 3/6] brcmfmac: fix for proper support of 160MHz bandwidth Arend van Spriel
2018-06-22 18:43 ` [PATCH 4/6] brcmfmac: increase buffer for obtaining firmware capabilities Arend van Spriel
2018-06-22 18:43 ` [PATCH 5/6] brcmfmac: add new feature flags for monitor mode operation Arend van Spriel
2018-06-22 18:43 ` [PATCH 6/6] brcmfmac: fallback mechanism to determine monitor mode features Arend van Spriel
2018-06-24 14:08 ` Rafał Miłecki
2018-06-25 8:21 ` Arend van Spriel
2018-06-24 11:48 ` [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Rafał Miłecki
2018-06-25 4:40 ` Rafał Miłecki
2018-06-25 8:31 ` Arend van Spriel [this message]
2018-06-25 8:43 ` Rafał Miłecki
2018-06-29 6:58 ` Kalle Valo
2018-08-29 20:17 ` Rafał Miłecki
2018-09-05 11:06 ` Arend van Spriel
2018-09-05 13:51 ` Rafał Miłecki
2018-06-25 8:18 ` Arend van Spriel
2018-06-25 8:43 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B30A85C.5080105@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).