* [PATCH] nfc: fix potential illegal memory access
@ 2019-01-21 14:51 Yang Wei
0 siblings, 0 replies; only message in thread
From: Yang Wei @ 2019-01-21 14:51 UTC (permalink / raw)
To: linux-wireless, netdev; +Cc: sameo, davem, yang.wei9, Yang Wei
The frags_q is used before __skb_queue_head_init when conn_info is
NULL. It may result in illegal memory access.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
net/nfc/nci/data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c
index 908f25e..8948341 100644
--- a/net/nfc/nci/data.c
+++ b/net/nfc/nci/data.c
@@ -116,14 +116,14 @@ static int nci_queue_tx_data_frags(struct nci_dev *ndev,
pr_debug("conn_id 0x%x, total_len %d\n", conn_id, total_len);
+ __skb_queue_head_init(&frags_q);
+
conn_info = nci_get_conn_info_by_conn_id(ndev, conn_id);
if (!conn_info) {
rc = -EPROTO;
goto free_exit;
}
- __skb_queue_head_init(&frags_q);
-
while (total_len) {
frag_len =
min_t(int, total_len, conn_info->max_pkt_payload_len);
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-21 14:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 14:51 [PATCH] nfc: fix potential illegal memory access Yang Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).