From: Siva Rebbagondla <siva8118@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
rishikesh.basu@redpinesignals.com,
siva.rebbagondla@redpinesignals.com,
krishna.pedda@redpinesignals.com,
ganapathi.kondraju@redpinesignals.com
Subject: [v2 3/5] rsi: fix wowlan wakeup issue for hibernate(S4)
Date: Thu, 31 Jan 2019 11:23:03 +0530 [thread overview]
Message-ID: <1548913985-7180-4-git-send-email-siva8118@gmail.com> (raw)
In-Reply-To: <1548913985-7180-1-git-send-email-siva8118@gmail.com>
From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
At SDIO restore ieee80211_restart_hw() is getting called to restart all
MAC operations. This step is not required.
Returning 1 from mac80211_resume() will serve this purpose.
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 8 ++++++--
drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 -
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index aded1ae..8d1282f 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -1938,8 +1938,12 @@ static int rsi_mac80211_resume(struct ieee80211_hw *hw)
rsi_dbg(INFO_ZONE, "%s: mac80211 resume\n", __func__);
- if (common->hibernate_resume)
- return 0;
+ if (common->hibernate_resume) {
+ /* Device need a complete restart of all MAC operations.
+ * returning 1 will serve this purpose.
+ */
+ return 1;
+ }
mutex_lock(&common->mutex);
rsi_send_wowlan_request(common, 0, 0);
diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
index 4005c1d..43e8a0d 100644
--- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
+++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
@@ -1393,7 +1393,6 @@ static int rsi_restore(struct device *dev)
common->iface_down = true;
adapter->sc_nvifs = 0;
- ieee80211_restart_hw(adapter->hw);
common->wow_flags = 0;
common->iface_down = false;
--
2.5.5
next prev parent reply other threads:[~2019-01-31 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 5:53 [v2 0/5] rsi: wowlan debig support and fixes Siva Rebbagondla
2019-01-31 5:53 ` [v2 1/5] rsi: Add debug support for wowlan wakeup confirmation Siva Rebbagondla
2019-01-31 5:53 ` [v2 2/5] rsi: add hci detach for hibernation and poweroff Siva Rebbagondla
2019-02-01 13:38 ` kbuild test robot
2019-02-01 15:05 ` kbuild test robot
2019-02-01 15:32 ` Siva Rebbagondla
2019-01-31 5:53 ` Siva Rebbagondla [this message]
2019-01-31 5:53 ` [v2 4/5] rsi: resolve power save issue after S4 resume Siva Rebbagondla
2019-01-31 5:53 ` [v2 5/5] rsi: fix for wowlan wakeup failure Siva Rebbagondla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548913985-7180-4-git-send-email-siva8118@gmail.com \
--to=siva8118@gmail.com \
--cc=ganapathi.kondraju@redpinesignals.com \
--cc=krishna.pedda@redpinesignals.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rishikesh.basu@redpinesignals.com \
--cc=siva.rebbagondla@redpinesignals.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).