From: Siva Rebbagondla <siva8118@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
Rishikesh Basu <rishikesh.basu@redpinesignals.com>,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
Krishna Babu Pedda <krishna.pedda@redpinesignals.com>,
Ganapathiraju Kondraju <ganapathi.kondraju@redpinesignals.com>
Subject: Re: [v2 2/5] rsi: add hci detach for hibernation and poweroff
Date: Fri, 1 Feb 2019 21:02:28 +0530 [thread overview]
Message-ID: <CANGSkXT2-UJreyf71NBpXQjpaKf6RsRVzdz1wtys-8njd5hwdA@mail.gmail.com> (raw)
In-Reply-To: <1548913985-7180-3-git-send-email-siva8118@gmail.com>
Hi Kalle,
On Thu, Jan 31, 2019 at 11:23 AM Siva Rebbagondla <siva8118@gmail.com> wrote:
>
> From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
>
> As we missed to detach HCI, while entering power off or hibernation,
> an extra hci interface gets created whenever system is woken up, to
> avoid this we added hci_detach() in rsi_disconnect(), rsi_freeze(),
> and rsi_shutdown() functions which are invoked for these tests.
> This patch fixes the issue
>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> ---
> drivers/net/wireless/rsi/rsi_91x_sdio.c | 15 +++++++++++++++
> drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
> index b412b65e..4005c1d 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
> @@ -1132,6 +1132,11 @@ static void rsi_disconnect(struct sdio_func *pfunction)
> rsi_mac80211_detach(adapter);
> mdelay(10);
>
> + if (adapter->priv->coex_mode > 1 && adapter->priv->bt_adapter) {
> + rsi_bt_ops.detach(adapter->priv->bt_adapter);
> + adapter->priv->bt_adapter = NULL;
> + }
> +
> /* Reset Chip */
> rsi_reset_chip(adapter);
>
> @@ -1308,6 +1313,11 @@ static int rsi_freeze(struct device *dev)
> rsi_dbg(ERR_ZONE,
> "##### Device can not wake up through WLAN\n");
>
> + if (common->coex_mode > 1 && common->bt_adapter) {
> + rsi_bt_ops.detach(common->bt_adapter);
> + common->bt_adapter = NULL;
> + }
> +
> ret = rsi_sdio_disable_interrupts(pfunction);
>
> if (sdev->write_fail)
> @@ -1355,6 +1365,11 @@ static void rsi_shutdown(struct device *dev)
> if (rsi_config_wowlan(adapter, wowlan))
> rsi_dbg(ERR_ZONE, "Failed to configure WoWLAN\n");
>
> + if (adapter->priv->coex_mode > 1 && adapter->priv->bt_adapter) {
> + rsi_bt_ops.detach(adapter->priv->bt_adapter);
> + adapter->priv->bt_adapter = NULL;
> + }
> +
> rsi_sdio_disable_interrupts(sdev->pfunction);
>
> if (sdev->write_fail)
> diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
> index f360690..38b4880b 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_usb.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
> @@ -816,6 +816,12 @@ static void rsi_disconnect(struct usb_interface *pfunction)
> return;
>
> rsi_mac80211_detach(adapter);
> +
> + if (adapter->priv->coex_mode > 1 && adapter->priv->bt_adapter) {
> + rsi_bt_ops.detach(adapter->priv->bt_adapter);
> + adapter->priv->bt_adapter = NULL;
> + }
> +
> rsi_reset_card(adapter);
> rsi_deinit_usb_interface(adapter);
> rsi_91x_deinit(adapter);
> --
> 2.5.5
>
Kindly ignore this patch series as kbuild test got failed. It is
because of "rsi_bt_ops". These ops are defined in
drivers/bluetooth/btrsi.c and this file is under CONFIG_RSI_COEX flag.
I was overlooked on this.
As you suggested in v1 series, I will resend these patches with
"IS_ENABLED(CONFIG_RSI_COEX)" check.
Thanks,
Siva Rebbagondla
next prev parent reply other threads:[~2019-02-01 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 5:53 [v2 0/5] rsi: wowlan debig support and fixes Siva Rebbagondla
2019-01-31 5:53 ` [v2 1/5] rsi: Add debug support for wowlan wakeup confirmation Siva Rebbagondla
2019-01-31 5:53 ` [v2 2/5] rsi: add hci detach for hibernation and poweroff Siva Rebbagondla
2019-02-01 13:38 ` kbuild test robot
2019-02-01 15:05 ` kbuild test robot
2019-02-01 15:32 ` Siva Rebbagondla [this message]
2019-01-31 5:53 ` [v2 3/5] rsi: fix wowlan wakeup issue for hibernate(S4) Siva Rebbagondla
2019-01-31 5:53 ` [v2 4/5] rsi: resolve power save issue after S4 resume Siva Rebbagondla
2019-01-31 5:53 ` [v2 5/5] rsi: fix for wowlan wakeup failure Siva Rebbagondla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANGSkXT2-UJreyf71NBpXQjpaKf6RsRVzdz1wtys-8njd5hwdA@mail.gmail.com \
--to=siva8118@gmail.com \
--cc=ganapathi.kondraju@redpinesignals.com \
--cc=krishna.pedda@redpinesignals.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rishikesh.basu@redpinesignals.com \
--cc=siva.rebbagondla@redpinesignals.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).