* [PATCH] ath10k: Fix memory leak in qmi
@ 2019-06-25 14:25 Dundi Raviteja
2019-06-28 19:11 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dundi Raviteja @ 2019-06-25 14:25 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Dundi Raviteja
Currently the memory allocated for qmi handle is
not being freed during de-init which leads to memory leak.
Free the allocated qmi memory in qmi deinit
to avoid memory leak.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Dundi Raviteja <dundi@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/qmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 2e67878..dcbf20b 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -1003,6 +1003,7 @@ int ath10k_qmi_deinit(struct ath10k *ar)
qmi_handle_release(&qmi->qmi_hdl);
cancel_work_sync(&qmi->event_work);
destroy_workqueue(qmi->event_wq);
+ kfree(qmi);
ar_snoc->qmi = NULL;
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: Fix memory leak in qmi
2019-06-25 14:25 [PATCH] ath10k: Fix memory leak in qmi Dundi Raviteja
@ 2019-06-28 19:11 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-06-28 19:11 UTC (permalink / raw)
To: Dundi Raviteja; +Cc: ath10k, linux-wireless, Dundi Raviteja
Dundi Raviteja <dundi@codeaurora.org> wrote:
> Currently the memory allocated for qmi handle is
> not being freed during de-init which leads to memory leak.
>
> Free the allocated qmi memory in qmi deinit
> to avoid memory leak.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Dundi Raviteja <dundi@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
c709df58832c ath10k: Fix memory leak in qmi
--
https://patchwork.kernel.org/patch/11015647/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-28 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 14:25 [PATCH] ath10k: Fix memory leak in qmi Dundi Raviteja
2019-06-28 19:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).