Linux-Wireless Archive on
 help / color / Atom feed
* [RFC] cfg80211: Allow self managed devices to update global regulatory
@ 2019-09-06  3:15 Sriram R
  2019-09-06  7:44 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Sriram R @ 2019-09-06  3:15 UTC (permalink / raw)
  To: johannes; +Cc: linux-wireless, Sriram R

Currently, self managed drivers cannot update the global regulatory
using a regulatory hint from driver if the wiphy regd is already set
from other sources.
Due to this, when a regulatory hint is provided to cfg80211 from
self managed devices, the request gets ignored and global reg is
always at default, i.e World reg, DFS-UNSET.
Hence in such systems, the result of 'iw reg get' does not indicate a
valid global regd.

Hence, Allow setting the cfg80211 global regulatory when it is unset
and the requestor is a self managed device. At the same time, do not
propagate these hints to other devices in the system.

Signed-off-by: Sriram R <>
 net/wireless/reg.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 646107a..86c4460 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -3550,6 +3550,20 @@ static int reg_set_rd_driver(const struct ieee80211_regdomain *rd,
 	if (!request_wiphy)
 		return -ENODEV;
+	/* Update cfg80211 regdomain only if it's unset, in case a hint
+	 * is received from self managed wiphy. Ignore all other
+	 * processing from self managed wiphy's. Return EALREADY to avoid
+	 * updating other drivers.
+	 */
+	if (request_wiphy->regulatory_flags & REGULATORY_WIPHY_SELF_MANAGED) {
+		regd = get_cfg80211_regdom();
+		if (regd == cfg80211_world_regdom) {
+			reset_regdomains(false, rd);
+		}
+		return -EALREADY;
+	}
 	if (!driver_request->intersect) {
 		if (request_wiphy->regd)
 			return -EALREADY;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06  3:15 [RFC] cfg80211: Allow self managed devices to update global regulatory Sriram R
2019-09-06  7:44 ` Johannes Berg

Linux-Wireless Archive on

Archives are clonable:
	git clone --mirror linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ \
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox