* [PATCH -next 0/2] ipw2x00: remove some set but not used variables
@ 2019-11-16 7:41 zhengbin
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
2019-11-16 7:41 ` [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update' zhengbin
0 siblings, 2 replies; 6+ messages in thread
From: zhengbin @ 2019-11-16 7:41 UTC (permalink / raw)
To: stas.yakovlev, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
zhengbin (2):
ipw2x00: remove set but not used variable 'reason'
ipw2x00: remove set but not used variable 'force_update'
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 3 +--
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 ---
2 files changed, 1 insertion(+), 5 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason'
2019-11-16 7:41 [PATCH -next 0/2] ipw2x00: remove some set but not used variables zhengbin
@ 2019-11-16 7:41 ` zhengbin
2019-11-16 7:51 ` Kalle Valo
2019-11-20 7:34 ` Kalle Valo
2019-11-16 7:41 ` [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update' zhengbin
1 sibling, 2 replies; 6+ messages in thread
From: zhengbin @ 2019-11-16 7:41 UTC (permalink / raw)
To: stas.yakovlev, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ipw_wx_set_mlme:
drivers/net/wireless/intel/ipw2x00/ipw2200.c:6805:9: warning: variable reason set but not used [-Wunused-but-set-variable]
It is introduced by commit 367a1092b555 ("ipw2x00:
move under intel vendor directory"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index ed0f065..31e43fc 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -6788,9 +6788,6 @@ static int ipw_wx_set_mlme(struct net_device *dev,
{
struct ipw_priv *priv = libipw_priv(dev);
struct iw_mlme *mlme = (struct iw_mlme *)extra;
- __le16 reason;
-
- reason = cpu_to_le16(mlme->reason_code);
switch (mlme->cmd) {
case IW_MLME_DEAUTH:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update'
2019-11-16 7:41 [PATCH -next 0/2] ipw2x00: remove some set but not used variables zhengbin
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
@ 2019-11-16 7:41 ` zhengbin
2019-11-16 7:51 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: zhengbin @ 2019-11-16 7:41 UTC (permalink / raw)
To: stas.yakovlev, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/intel/ipw2x00/ipw2100.c: In function shim__set_security:
drivers/net/wireless/intel/ipw2x00/ipw2100.c:5582:9: warning: variable force_update set but not used [-Wunused-but-set-variable]
It is introduced by commit 367a1092b555 ("ipw2x00:
move under intel vendor directory"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 8dfbaff..c4c83ab 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -5565,7 +5565,7 @@ static void shim__set_security(struct net_device *dev,
struct libipw_security *sec)
{
struct ipw2100_priv *priv = libipw_priv(dev);
- int i, force_update = 0;
+ int i;
mutex_lock(&priv->action_mutex);
if (!(priv->status & STATUS_INITIALIZED))
@@ -5605,7 +5605,6 @@ static void shim__set_security(struct net_device *dev,
priv->ieee->sec.flags |= SEC_ENABLED;
priv->ieee->sec.enabled = sec->enabled;
priv->status |= STATUS_SECURITY_UPDATED;
- force_update = 1;
}
if (sec->flags & SEC_ENCRYPT)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason'
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
@ 2019-11-16 7:51 ` Kalle Valo
2019-11-20 7:34 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-11-16 7:51 UTC (permalink / raw)
To: zhengbin; +Cc: stas.yakovlev, davem, linux-wireless, netdev
zhengbin <zhengbin13@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ipw_wx_set_mlme:
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:6805:9: warning: variable reason set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 367a1092b555 ("ipw2x00:
> move under intel vendor directory"), but never used, so remove it.
No it's not, as the commit title says it's only moving files to a
different location. I'll remove that sentence from the commit log.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update'
2019-11-16 7:41 ` [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update' zhengbin
@ 2019-11-16 7:51 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-11-16 7:51 UTC (permalink / raw)
To: zhengbin; +Cc: stas.yakovlev, davem, linux-wireless, netdev
zhengbin <zhengbin13@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/intel/ipw2x00/ipw2100.c: In function shim__set_security:
> drivers/net/wireless/intel/ipw2x00/ipw2100.c:5582:9: warning: variable force_update set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 367a1092b555 ("ipw2x00:
> move under intel vendor directory"), but never used, so remove it.
Same here, I'll remove this sentence as well.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason'
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
2019-11-16 7:51 ` Kalle Valo
@ 2019-11-20 7:34 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-11-20 7:34 UTC (permalink / raw)
To: zhengbin; +Cc: stas.yakovlev, davem, linux-wireless, netdev, zhengbin13
zhengbin <zhengbin13@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ipw_wx_set_mlme:
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:6805:9: warning: variable reason set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
2 patches applied to wireless-drivers-next.git, thanks.
805a57acd7b5 ipw2x00: remove set but not used variable 'reason'
f89f1aefff5a ipw2x00: remove set but not used variable 'force_update'
--
https://patchwork.kernel.org/patch/11247481/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-20 7:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-16 7:41 [PATCH -next 0/2] ipw2x00: remove some set but not used variables zhengbin
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
2019-11-16 7:51 ` Kalle Valo
2019-11-20 7:34 ` Kalle Valo
2019-11-16 7:41 ` [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update' zhengbin
2019-11-16 7:51 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).