From: Wang Yufen <wangyufen@huawei.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<brcm80211-dev-list@cypress.com>,
<linux-wireless@vger.kernel.org>, <davem@davemloft.net>,
<kvalo@codeaurora.org>, <kuba@kernel.org>,
<franky.lin@broadcom.com>, <wright.feng@cypress.com>
Cc: Wang Yufen <wangyufen@huawei.com>
Subject: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
Date: Mon, 20 Jul 2020 17:33:28 +0800 [thread overview]
Message-ID: <1595237608-66045-1-git-send-email-wangyufen@huawei.com> (raw)
When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
we should destroy the workqueue.
Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
index 8bb4f1f..1bb270e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
@@ -1619,6 +1619,8 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
BRCMF_TX_IOCTL_MAX_MSG_SIZE,
msgbuf->ioctbuf,
msgbuf->ioctbuf_handle);
+ if (msgbuf->txflow_wq)
+ destroy_workqueue(msgbuf->txflow_wq);
kfree(msgbuf);
}
return -ENOMEM;
--
1.8.3
next reply other threads:[~2020-07-20 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:33 Wang Yufen [this message]
2020-07-20 9:36 [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Wang Yufen
2020-08-02 15:29 ` Kalle Valo
2020-08-18 12:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595237608-66045-1-git-send-email-wangyufen@huawei.com \
--to=wangyufen@huawei.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).