From: Kalle Valo <kvalo@codeaurora.org>
To: Wang Yufen <wangyufen@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<brcm80211-dev-list@cypress.com>,
<linux-wireless@vger.kernel.org>, <davem@davemloft.net>,
<kuba@kernel.org>, <franky.lin@broadcom.com>,
<wright.feng@cypress.com>, Wang Yufen <wangyufen@huawei.com>
Subject: Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
Date: Sun, 2 Aug 2020 15:29:51 +0000 (UTC) [thread overview]
Message-ID: <20200802152951.3F2C4C433C6@smtp.codeaurora.org> (raw)
In-Reply-To: <1595237765-66238-1-git-send-email-wangyufen@huawei.com>
Wang Yufen <wangyufen@huawei.com> wrote:
> When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
> we should destroy the workqueue.
>
> Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")
Moving the driver to another directory cannot have caused this bug, so I'm
removing the fixes tag. Please check your commit logs, don't just blindly copy
what git-blame says.
--
https://patchwork.kernel.org/patch/11673291/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-02 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:36 [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Wang Yufen
2020-08-02 15:29 ` Kalle Valo [this message]
2020-08-18 12:47 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-07-20 9:33 Wang Yufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802152951.3F2C4C433C6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=brcm80211-dev-list@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangyufen@huawei.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).