* [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
@ 2021-10-15 15:21 Colin King
2021-10-18 1:30 ` Pkshih
2021-10-18 12:31 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-10-15 15:21 UTC (permalink / raw)
To: Kalle Valo, David S . Miller, Jakub Kicinski, Ping-Ke Shih,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function rtw89_mac_enable_bb_rf is a void return type, so there is
no return error code to ret, so the following check for an error in ret
is redundant dead code and can be removed.
Addresses-Coverity: ("Logically dead code")
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtw89/mac.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 0171a5a7b1de..69384c43c046 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
goto fail;
rtw89_mac_enable_bb_rf(rtwdev);
- if (ret)
- goto fail;
ret = rtw89_mac_sys_init(rtwdev);
if (ret)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
2021-10-15 15:21 [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf Colin King
@ 2021-10-18 1:30 ` Pkshih
2021-10-18 12:31 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2021-10-18 1:30 UTC (permalink / raw)
To: Colin King, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: Friday, October 15, 2021 11:21 PM
> To: Kalle Valo <kvalo@codeaurora.org>; David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Pkshih <pkshih@realtek.com>; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The function rtw89_mac_enable_bb_rf is a void return type, so there is
> no return error code to ret, so the following check for an error in ret
> is redundant dead code and can be removed.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/mac.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c
> b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..69384c43c046 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
> goto fail;
>
> rtw89_mac_enable_bb_rf(rtwdev);
> - if (ret)
> - goto fail;
>
> ret = rtw89_mac_sys_init(rtwdev);
> if (ret)
> --
> 2.32.0
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
2021-10-15 15:21 [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf Colin King
2021-10-18 1:30 ` Pkshih
@ 2021-10-18 12:31 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-10-18 12:31 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Jakub Kicinski, Ping-Ke Shih, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function rtw89_mac_enable_bb_rf is a void return type, so there is
> no return error code to ret, so the following check for an error in ret
> is redundant dead code and can be removed.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
f7e7e440550b rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211015152113.33179-1-colin.king@canonical.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-18 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 15:21 [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf Colin King
2021-10-18 1:30 ` Pkshih
2021-10-18 12:31 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).