From: Kalle Valo <kvalo@codeaurora.org>
To: Nick Hainke <vincent@systemli.org>
Cc: nbd@nbd.name, lorenzo.bianconi83@gmail.com,
ryder.lee@mediatek.com, davem@davemloft.net, kuba@kernel.org,
matthias.bgg@gmail.com, sean.wang@mediatek.com,
shayne.chen@mediatek.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Robert Foss <robert.foss@linaro.org>,
Nick Hainke <vincent@systemli.org>
Subject: Re: [RFC,v2] mt76: mt7615: mt7622: fix ibss and meshpoint
Date: Sat, 23 Oct 2021 07:30:09 +0000 (UTC) [thread overview]
Message-ID: <163497420151.29616.16838354269777236200.kvalo@codeaurora.org> (raw)
In-Reply-To: <20211007225725.2615-1-vincent@systemli.org>
Nick Hainke <vincent@systemli.org> wrote:
> commit 7f4b7920318b ("mt76: mt7615: add ibss support") introduced IBSS
> and commit f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")
> meshpoint support.
>
> Both used in the "get_omac_idx"-function:
>
> if (~mask & BIT(HW_BSSID_0))
> return HW_BSSID_0;
>
> With commit d8d59f66d136 ("mt76: mt7615: support 16 interfaces") the
> ibss and meshpoint mode should "prefer hw bssid slot 1-3". However,
> with that change the ibss or meshpoint mode will not send any beacon on
> the mt7622 wifi anymore. Devices were still able to exchange data but
> only if a bssid already existed. Two mt7622 devices will never be able
> to communicate.
>
> This commits reverts the preferation of slot 1-3 for ibss and
> meshpoint. Only NL80211_IFTYPE_STATION will still prefer slot 1-3.
>
> Tested on Banana Pi R64.
>
> Fixes: d8d59f66d136 ("mt76: mt7615: support 16 interfaces")
> Signed-off-by: Nick Hainke <vincent@systemli.org>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers-next.git, thanks.
753453afacc0 mt76: mt7615: mt7622: fix ibss and meshpoint
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211007225725.2615-1-vincent@systemli.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-10-23 7:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 22:57 [RFC v2] mt76: mt7615: mt7622: fix ibss and meshpoint Nick Hainke
2021-10-09 8:32 ` Kalle Valo
2021-10-09 10:37 ` Nick
2021-10-09 13:22 ` Daniel Golle
2021-10-11 9:12 ` Nick
2021-10-17 12:28 ` Aw: " Frank Wunderlich
2021-10-17 13:52 ` Daniel Golle
2021-10-18 10:11 ` Nick
2021-10-18 10:13 ` Nick
2021-10-18 10:16 ` Felix Fietkau
2021-10-19 7:19 ` Kalle Valo
2021-10-23 7:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163497420151.29616.16838354269777236200.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robert.foss@linaro.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).