From: Felix Fietkau <nbd@nbd.name>
To: Kalle Valo <kvalo@codeaurora.org>, Nick Hainke <vincent@systemli.org>
Cc: lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
davem@davemloft.net, kuba@kernel.org, matthias.bgg@gmail.com,
sean.wang@mediatek.com, shayne.chen@mediatek.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Robert Foss <robert.foss@linaro.org>
Subject: Re: [RFC v2] mt76: mt7615: mt7622: fix ibss and meshpoint
Date: Mon, 18 Oct 2021 12:16:00 +0200 [thread overview]
Message-ID: <569d434d-cf5b-6ab0-5931-41b21ab047b7@nbd.name> (raw)
In-Reply-To: <87czoe61kh.fsf@codeaurora.org>
On 2021-10-09 10:32, Kalle Valo wrote:
> Nick Hainke <vincent@systemli.org> writes:
>
>> Fixes: d8d59f66d136 ("mt76: mt7615: support 16 interfaces").
>
> The fixes tag should be in the end, before Signed-off-by tags. But I can
> fix that during commit.
>
>> commit 7f4b7920318b ("mt76: mt7615: add ibss support") introduced IBSS
>> and commit f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")
>> meshpoint support.
>>
>> Both used in the "get_omac_idx"-function:
>>
>> if (~mask & BIT(HW_BSSID_0))
>> return HW_BSSID_0;
>>
>> With commit d8d59f66d136 ("mt76: mt7615: support 16 interfaces") the
>> ibss and meshpoint mode should "prefer hw bssid slot 1-3". However,
>> with that change the ibss or meshpoint mode will not send any beacon on
>> the mt7622 wifi anymore. Devices were still able to exchange data but
>> only if a bssid already existed. Two mt7622 devices will never be able
>> to communicate.
>>
>> This commits reverts the preferation of slot 1-3 for ibss and
>> meshpoint. Only NL80211_IFTYPE_STATION will still prefer slot 1-3.
>>
>> Tested on Banana Pi R64.
>>
>> Signed-off-by: Nick Hainke <vincent@systemli.org>
>
> Felix, can I take this to wireless-drivers? Ack?
Acked-by: Felix Fietkau <nbd@nbd.name>
next prev parent reply other threads:[~2021-10-18 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 22:57 [RFC v2] mt76: mt7615: mt7622: fix ibss and meshpoint Nick Hainke
2021-10-09 8:32 ` Kalle Valo
2021-10-09 10:37 ` Nick
2021-10-09 13:22 ` Daniel Golle
2021-10-11 9:12 ` Nick
2021-10-17 12:28 ` Aw: " Frank Wunderlich
2021-10-17 13:52 ` Daniel Golle
2021-10-18 10:11 ` Nick
2021-10-18 10:13 ` Nick
2021-10-18 10:16 ` Felix Fietkau [this message]
2021-10-19 7:19 ` Kalle Valo
2021-10-23 7:30 ` [RFC,v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569d434d-cf5b-6ab0-5931-41b21ab047b7@nbd.name \
--to=nbd@nbd.name \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert.foss@linaro.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).