linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions
@ 2021-10-21  5:44 Kevin Lo
  2021-10-21  6:08 ` Pkshih
  2021-10-27  7:36 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Kevin Lo @ 2021-10-21  5:44 UTC (permalink / raw)
  To: linux-wireless; +Cc: Pkshih

Remove duplicate register definitions.

Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
index 34333c441aea..20e6767ea5c4 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.h
+++ b/drivers/net/wireless/realtek/rtw89/pci.h
@@ -276,11 +276,6 @@
 #define B_AX_CH10_BUSY			BIT(0)
 
 /* Configure */
-#define R_AX_PCIE_INIT_CFG1	0x1000
-#define B_AX_PCIE_RXRST_KEEP_REG	BIT(23)
-#define B_AX_PCIE_TXRST_KEEP_REG	BIT(22)
-#define B_AX_DIS_RXDMA_PRE		BIT(2)
-
 #define R_AX_PCIE_INIT_CFG2		0x1004
 #define B_AX_WD_ITVL_IDLE		GENMASK(27, 24)
 #define B_AX_WD_ITVL_ACT		GENMASK(19, 16)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions
  2021-10-21  5:44 [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions Kevin Lo
@ 2021-10-21  6:08 ` Pkshih
  2021-10-27  7:36 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2021-10-21  6:08 UTC (permalink / raw)
  To: Kevin Lo, linux-wireless


> -----Original Message-----
> From: Kevin Lo <kevlo@kevlo.org>
> Sent: Thursday, October 21, 2021 1:44 PM
> To: linux-wireless@vger.kernel.org
> Cc: Pkshih <pkshih@realtek.com>
> Subject: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions
> 
> Remove duplicate register definitions.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
> index 34333c441aea..20e6767ea5c4 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.h
> +++ b/drivers/net/wireless/realtek/rtw89/pci.h
> @@ -276,11 +276,6 @@
>  #define B_AX_CH10_BUSY			BIT(0)
> 
>  /* Configure */
> -#define R_AX_PCIE_INIT_CFG1	0x1000
> -#define B_AX_PCIE_RXRST_KEEP_REG	BIT(23)
> -#define B_AX_PCIE_TXRST_KEEP_REG	BIT(22)
> -#define B_AX_DIS_RXDMA_PRE		BIT(2)
> -
>  #define R_AX_PCIE_INIT_CFG2		0x1004
>  #define B_AX_WD_ITVL_IDLE		GENMASK(27, 24)
>  #define B_AX_WD_ITVL_ACT		GENMASK(19, 16)
> ------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions
  2021-10-21  5:44 [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions Kevin Lo
  2021-10-21  6:08 ` Pkshih
@ 2021-10-27  7:36 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-10-27  7:36 UTC (permalink / raw)
  To: Kevin Lo; +Cc: linux-wireless, Pkshih

Kevin Lo <kevlo@kevlo.org> wrote:

> Remove duplicate register definitions.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
> index 34333c441aea..20e6767ea5c4 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.h
> +++ b/drivers/net/wireless/realtek/rtw89/pci.h
> @@ -276,11 +276,6 @@
>  #define B_AX_CH10_BUSY			BIT(0)
>  
>  /* Configure */
> -#define R_AX_PCIE_INIT_CFG1	0x1000
> -#define B_AX_PCIE_RXRST_KEEP_REG	BIT(23)
> -#define B_AX_PCIE_TXRST_KEEP_REG	BIT(22)
> -#define B_AX_DIS_RXDMA_PRE		BIT(2)
> -
>  #define R_AX_PCIE_INIT_CFG2		0x1004
>  #define B_AX_WD_ITVL_IDLE		GENMASK(27, 24)
>  #define B_AX_WD_ITVL_ACT		GENMASK(19, 16)

Patch applied to wireless-drivers-next.git, thanks.

090f8a2f7b38 rtw89: remove duplicate register definitions

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YXD+KL+xzFsnGShb@ns.kevlo.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-27  7:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21  5:44 [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions Kevin Lo
2021-10-21  6:08 ` Pkshih
2021-10-27  7:36 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).