* [PATCH] ath11k: Fix 'unused-but-set-parameter' error
@ 2021-11-11 5:52 Seevalamuthu Mariappan
2021-11-15 9:18 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Seevalamuthu Mariappan @ 2021-11-11 5:52 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Seevalamuthu Mariappan
Below compilation error is reported when built with W=1,
drivers/net/wireless/ath/ath11k/mac.c:5408:22: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
changed_flags is set, but left unused. So, remove unnecessary set.
Compile tested only.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 89810b2..6f3130d 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -5919,7 +5919,6 @@ static void ath11k_mac_op_configure_filter(struct ieee80211_hw *hw,
mutex_lock(&ar->conf_mutex);
- changed_flags &= SUPPORTED_FILTERS;
*total_flags &= SUPPORTED_FILTERS;
ar->filter_flags = *total_flags;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: Fix 'unused-but-set-parameter' error
2021-11-11 5:52 [PATCH] ath11k: Fix 'unused-but-set-parameter' error Seevalamuthu Mariappan
@ 2021-11-15 9:18 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-11-15 9:18 UTC (permalink / raw)
To: Seevalamuthu Mariappan; +Cc: ath11k, linux-wireless, Seevalamuthu Mariappan
Seevalamuthu Mariappan <quic_seevalam@quicinc.com> wrote:
> Below compilation error is reported when built with W=1,
>
> drivers/net/wireless/ath/ath11k/mac.c:5408:22: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
>
> changed_flags is set, but left unused. So, remove unnecessary set.
> Compile tested only.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
624e0a317030 ath11k: Fix 'unused-but-set-parameter' error
--
https://patchwork.kernel.org/project/linux-wireless/patch/1636609967-5114-1-git-send-email-quic_seevalam@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-15 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 5:52 [PATCH] ath11k: Fix 'unused-but-set-parameter' error Seevalamuthu Mariappan
2021-11-15 9:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).