[PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

[PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

[Tom Rix]

clang with W=1 reports
drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
  unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
                    ^
This function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/wireless/realtek/rtw88/pci.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index b4bd831c9845..6a8e6ee82069 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -89,13 +89,6 @@ static void rtw_pci_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
 	writel(val, rtwpci->mmap + addr);
 }
 
-static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
-{
-	int offset = tx_ring->r.desc_size * idx;
-
-	return tx_ring->r.head + offset;
-}
-
 static void rtw_pci_free_tx_ring_skbs(struct rtw_dev *rtwdev,
 				      struct rtw_pci_tx_ring *tx_ring)
 {
-- 
2.27.0

RE: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

[Ping-Ke Shih]

> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Tuesday, March 21, 2023 7:35 AM
> To: tony0620emma@gmail.com; kvalo@kernel.org; davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; nathan@kernel.org; ndesaulniers@google.com
> Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> llvm@lists.linux.dev; Tom Rix <trix@redhat.com>
> Subject: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function
> 
> clang with W=1 reports
> drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
>   unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
> static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
>                     ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index b4bd831c9845..6a8e6ee82069 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -89,13 +89,6 @@ static void rtw_pci_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
>         writel(val, rtwpci->mmap + addr);
>  }
> 
> -static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
> -{
> -       int offset = tx_ring->r.desc_size * idx;
> -
> -       return tx_ring->r.head + offset;
> -}
> -
>  static void rtw_pci_free_tx_ring_skbs(struct rtw_dev *rtwdev,
>                                       struct rtw_pci_tx_ring *tx_ring)
>  {
> --
> 2.27.0

Re: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

[Kalle Valo]

Tom Rix <trix@redhat.com> wrote:

> clang with W=1 reports
> drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
>   unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
> static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
>                     ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

c9b6111a6f94 wifi: rtw88: remove unused rtw_pci_get_tx_desc function

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230320233448.1729899-1-trix@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches