From: Sujith <m.sujith@gmail.com>
To: "Björn Smedman" <bjorn.smedman@venatech.se>
Cc: Rajkumar Manoharan <rmanoharan@atheros.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] ath9k: Handle interface changes properly
Date: Wed, 12 Jan 2011 22:52:23 +0530 [thread overview]
Message-ID: <19757.58191.865301.805439@gargle.gargle.HOWL> (raw)
In-Reply-To: <AANLkTi=S6TFk88cY27KFZ2q5mCykMMSn17LnH=V95MST@mail.gmail.com>
Björn Smedman wrote:
> On Wed, Jan 12, 2011 at 3:30 PM, Rajkumar Manoharan
> <rmanoharan@atheros.com> wrote:
> > The commit ""ath9k: Add change_interface callback" was failed
> > to update of hw opmode, ani and interrupt mask. This leads
> > to break p2p functionality on ath9k. And the existing add and
> > remove interface functions are not handling hw opmode and
> > ANI properly.
> >
> > This patch combines the common code in interface callbacks
> > and also takes care of multi-vif cases.
>
> How does your patch handle the race condition between the interface
> change done in process context and the beacon tasklet triggered by
> SWBA?
>
> Also, perhaps more applicable to the commit log than the patch, how
> can opmode be properly handled in multi-vif cases? I mean let's say I
> have two AP vifs and then change one into STA, is the opmode then STA?
> Compare that to the case where I have two STA vifs and change one into
> AP; so again I have one AP and one STA vif but this time opmode is AP,
> right? I can see how I can be wrong about these examples but I can't
> really see how the opmode concept can be properly handled in multi-vif
> cases.
The opmode should be calculated every time an interface is created/destroyed.
If an AP vif is already present when a STA is added, the opmode remains as AP.
if a STA vif is changed into AP mode, then the opmode should be changed to AP,
along with disabling PS for other STA interfaces.
If an AP is present and a STA is added, the beacon interval can't be different.
And there are a few other conditions as well...
And you are right, interface management is not protected with the beacon tasklet...
Sujith
next prev parent reply other threads:[~2011-01-12 17:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 14:30 [RFC] ath9k: Handle interface changes properly Rajkumar Manoharan
2011-01-12 17:06 ` Björn Smedman
2011-01-12 17:22 ` Sujith [this message]
2011-01-12 19:00 ` Björn Smedman
2011-01-13 1:56 ` Sujith
2011-01-13 5:16 ` Rajkumar Manoharan
2011-01-13 5:10 ` Rajkumar Manoharan
2011-01-12 19:51 ` Felix Fietkau
2011-01-12 20:14 ` Ben Greear
2011-01-13 5:18 ` Rajkumar Manoharan
2011-01-13 14:23 ` Felix Fietkau
2011-01-13 16:35 ` Rajkumar Manoharan
2011-01-13 16:49 ` Felix Fietkau
2011-01-14 18:13 ` Rajkumar Manoharan
2011-01-14 18:22 ` Felix Fietkau
2011-01-14 18:53 ` Rajkumar Manoharan
2011-01-14 19:06 ` Felix Fietkau
2011-01-14 19:24 ` Rajkumar Manoharan
2011-01-14 19:29 ` Ben Greear
2011-01-14 19:34 ` Felix Fietkau
2011-01-14 23:02 ` Björn Smedman
2011-01-13 5:08 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19757.58191.865301.805439@gargle.gargle.HOWL \
--to=m.sujith@gmail.com \
--cc=bjorn.smedman@venatech.se \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).