linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Rajkumar Manoharan" <rmanoharan@Atheros.com>,
	"Rajkumar Manoharan" <Rajkumar.Manoharan@Atheros.com>,
	"Björn Smedman" <bjorn.smedman@venatech.se>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] ath9k: Handle interface changes properly
Date: Fri, 14 Jan 2011 20:34:19 +0100	[thread overview]
Message-ID: <4D30A53B.5050603@openwrt.org> (raw)
In-Reply-To: <4D30A3FC.7040609@candelatech.com>

On 2011-01-14 8:29 PM, Ben Greear wrote:
> On 01/14/2011 11:24 AM, Rajkumar Manoharan wrote:
>>  On Sat, Jan 15, 2011 at 12:36:42AM +0530, Felix Fietkau wrote:
>>>  On 2011-01-14 7:53 PM, Rajkumar Manoharan wrote:
>>>>  On Fri, Jan 14, 2011 at 11:52:02PM +0530, Felix Fietkau wrote:
>>>>>    On 2011-01-14 7:13 PM, Rajkumar Manoharan wrote:
>>>>>    >    On Thu, Jan 13, 2011 at 10:19:38PM +0530, Felix Fietkau wrote:
>>>>>    >>     On 2011-01-13 5:35 PM, Rajkumar Manoharan wrote:
>>>>>    >>     >     Instead of setting opmde as AP for WDS, it is better to handle WDS
>>>>>    >>     >     case in ath9k_hw.
>>>>>    >>     Why? Right now I don't even see any NL80211_IFTYPE_WDS handling in
>>>>>    >>     ath9k_hw, and I can't think of anything that should be handled
>>>>>    >>     differently in ath9k_hw compared to the AP opmode.
>>>>>    >    For WDS station, what should be the interface type? Forgive if I'm wrong.
>>>>>    There is no WDS station opmode. 'WDS station' is a regular station
>>>>>    interface with 4-addr mode enabled. It needs no special handling in ath9k.
>>>>  still not convinced. Then what is the point mac80211 is informing about
>>>>  WDS type to drivers. mac itself can pass it as AP type like what it
>>>>  is doing for p2p GO.
>>>  The WDS type is something else. If you have two APs, you can link them
>>>  together with a separate WDS vif on each side pointing at the remote MAC
>>>  address of the other node.
>>>  I think that when we use ah->opmode, we should only use it for very
>>>  generic operating modes:
>>>
>>>  AP: no TSF sync, beacon tx can be enabled.
>>>  ADHOC: TSF sync against IBSS cell, beacon tx can be enabled
>>>  STATION: TSF sync against one AP, only station beacon timers for PS.
>>>
>>>  Only the above distinctions are relevant for ath9k_hw, everything else
>>>  is handled by the driver/stack. There is no reason for adding extra
>>>  checks to ath9k_hw for mesh and WDS, since they work best with
>>>  ah->opmode set to AP, and there is nothing extra on the *hardware* side
>>>  that should be configured there via a different opmode. That's why I
>>>  think leaking the mac80211 interface types to ath9k_hw is a bad idea.
>>  Thanks for your detailed explanation. And meanwhile Ben is also
>>  fixing hw mode based on vif counter. It would be better if he make
>>  use this thread and address the same.
>>
>>  Ben,
>>  Any comments.
>
> If all I need to do is to treat WDS and MESH like an AP, that shouldn't
> be too hard.
>
> Does WDS need a beacon?
No

> Is there any limitations to the number of WDS vifs allowed, including
> combinations with other VIF types?
I don't think so.

- Felix

  reply	other threads:[~2011-01-14 19:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 14:30 [RFC] ath9k: Handle interface changes properly Rajkumar Manoharan
2011-01-12 17:06 ` Björn Smedman
2011-01-12 17:22   ` Sujith
2011-01-12 19:00     ` Björn Smedman
2011-01-13  1:56       ` Sujith
2011-01-13  5:16       ` Rajkumar Manoharan
2011-01-13  5:10     ` Rajkumar Manoharan
2011-01-12 19:51   ` Felix Fietkau
2011-01-12 20:14     ` Ben Greear
2011-01-13  5:18     ` Rajkumar Manoharan
2011-01-13 14:23       ` Felix Fietkau
2011-01-13 16:35         ` Rajkumar Manoharan
2011-01-13 16:49           ` Felix Fietkau
2011-01-14 18:13             ` Rajkumar Manoharan
2011-01-14 18:22               ` Felix Fietkau
2011-01-14 18:53                 ` Rajkumar Manoharan
2011-01-14 19:06                   ` Felix Fietkau
2011-01-14 19:24                     ` Rajkumar Manoharan
2011-01-14 19:29                       ` Ben Greear
2011-01-14 19:34                         ` Felix Fietkau [this message]
2011-01-14 23:02                     ` Björn Smedman
2011-01-13  5:08   ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D30A53B.5050603@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=Rajkumar.Manoharan@Atheros.com \
    --cc=bjorn.smedman@venatech.se \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanoharan@Atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).