* Re: [PATCH 5/9] drivers/net/wireless: correct error-handling code [not found] <Pine.LNX.4.64.0907281753540.28189@ask.diku.dk> @ 2009-07-28 17:30 ` David Miller 2009-07-28 17:52 ` John W. Linville 2009-07-28 18:06 ` [PATCH] MAINTAINERS: Add networking wireless drivers section Joe Perches 0 siblings, 2 replies; 11+ messages in thread From: David Miller @ 2009-07-28 17:30 UTC (permalink / raw) To: julia; +Cc: netdev, linux-kernel, kernel-janitors, linux-wireless From: Julia Lawall <julia@diku.dk> Date: Tue, 28 Jul 2009 17:54:24 +0200 (CEST) Wireless patches need to be CC:'d to linux-wireless so that John Linville can notice and pick them up. Added... > From: Julia Lawall <julia@diku.dk> > > iwm_wdev_alloc returns an ERR_PTR value in an error case instead of NULL. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @match exists@ > expression x, E; > statement S1, S2; > @@ > > x = iwm_wdev_alloc(...) > ... when != x = E > ( > * if (x == NULL || ...) S1 else S2 > | > * if (x == NULL && ...) S1 else S2 > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > drivers/net/wireless/iwmc3200wifi/netdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/iwmc3200wifi/netdev.c b/drivers/net/wireless/iwmc3200wifi/netdev.c > index bb71f8a..e1c6693 100644 > --- a/drivers/net/wireless/iwmc3200wifi/netdev.c > +++ b/drivers/net/wireless/iwmc3200wifi/netdev.c > @@ -99,7 +99,7 @@ void *iwm_if_alloc(int sizeof_bus, struct device *dev, > int ret = 0; > > wdev = iwm_wdev_alloc(sizeof_bus, dev); > - if (!wdev) { > + if (IS_ERR(wdev)) { > dev_err(dev, "no memory for wireless device instance\n"); > return ERR_PTR(-ENOMEM); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/9] drivers/net/wireless: correct error-handling code 2009-07-28 17:30 ` [PATCH 5/9] drivers/net/wireless: correct error-handling code David Miller @ 2009-07-28 17:52 ` John W. Linville 2009-07-28 18:06 ` [PATCH] MAINTAINERS: Add networking wireless drivers section Joe Perches 1 sibling, 0 replies; 11+ messages in thread From: John W. Linville @ 2009-07-28 17:52 UTC (permalink / raw) To: David Miller; +Cc: julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, Jul 28, 2009 at 10:30:44AM -0700, David Miller wrote: > From: Julia Lawall <julia@diku.dk> > Date: Tue, 28 Jul 2009 17:54:24 +0200 (CEST) > > Wireless patches need to be CC:'d to linux-wireless so that > John Linville can notice and pick them up. Added... Thanks...FWIW, I've got a nearly identical patch from Dan Carpenter queued already. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ¡Viva Honduras Libre! ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 17:30 ` [PATCH 5/9] drivers/net/wireless: correct error-handling code David Miller 2009-07-28 17:52 ` John W. Linville @ 2009-07-28 18:06 ` Joe Perches 2009-07-28 18:15 ` Randy Dunlap 2009-07-28 18:33 ` David Miller 1 sibling, 2 replies; 11+ messages in thread From: Joe Perches @ 2009-07-28 18:06 UTC (permalink / raw) To: David Miller, John W. Linville Cc: julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: > Wireless patches need to be CC:'d to linux-wireless so that > John Linville can notice and pick them up Signed-off-by: Joe Perches <joe@perches.com> diff --git a/MAINTAINERS b/MAINTAINERS index ebc2691..0574aad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4186,6 +4186,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git S: Odd Fixes F: drivers/net/ +NETWORKING WIRELESS DRIVERS +L: linux-wireless@vger.kernel.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git +S: Odd Fixes +F: drivers/net/wireless/ + NETXEN (1/10) GbE SUPPORT P: Dhananjay Phadke M: dhananjay@netxen.com ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:06 ` [PATCH] MAINTAINERS: Add networking wireless drivers section Joe Perches @ 2009-07-28 18:15 ` Randy Dunlap 2009-07-28 18:27 ` Joe Perches 2009-07-28 18:33 ` David Miller 1 sibling, 1 reply; 11+ messages in thread From: Randy Dunlap @ 2009-07-28 18:15 UTC (permalink / raw) To: Joe Perches Cc: David Miller, John W. Linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, 28 Jul 2009 11:06:37 -0700 Joe Perches wrote: > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: > > Wireless patches need to be CC:'d to linux-wireless so that > > John Linville can notice and pick them up > > Signed-off-by: Joe Perches <joe@perches.com> > > diff --git a/MAINTAINERS b/MAINTAINERS > index ebc2691..0574aad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4186,6 +4186,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git > S: Odd Fixes > F: drivers/net/ > > +NETWORKING WIRELESS DRIVERS > +L: linux-wireless@vger.kernel.org > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git > +S: Odd Fixes > +F: drivers/net/wireless/ > + Already have this: NETWORKING [WIRELESS] P: John W. Linville M: linville@tuxdriver.com L: linux-wireless@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git S: Maintained F: net/wireless/ F: include/net/ieee80211* F: include/linux/wireless.h --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:15 ` Randy Dunlap @ 2009-07-28 18:27 ` Joe Perches 2009-07-28 18:34 ` David Miller 0 siblings, 1 reply; 11+ messages in thread From: Joe Perches @ 2009-07-28 18:27 UTC (permalink / raw) To: Randy Dunlap Cc: David Miller, John W. Linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, 2009-07-28 at 11:15 -0700, Randy Dunlap wrote: > On Tue, 28 Jul 2009 11:06:37 -0700 Joe Perches wrote: > > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: > > > Wireless patches need to be CC:'d to linux-wireless so that > > > John Linville can notice and pick them up > > Signed-off-by: Joe Perches <joe@perches.com> > > diff --git a/MAINTAINERS b/MAINTAINERS > > index ebc2691..0574aad 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -4186,6 +4186,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git > > S: Odd Fixes > > F: drivers/net/ > > > > +NETWORKING WIRELESS DRIVERS > > +L: linux-wireless@vger.kernel.org > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git > > +S: Odd Fixes > > +F: drivers/net/wireless/ > > + > > Already have this: > > NETWORKING [WIRELESS] > P: John W. Linville > M: linville@tuxdriver.com > L: linux-wireless@vger.kernel.org > T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git > S: Maintained > F: net/wireless/ > F: include/net/ieee80211* > F: include/linux/wireless.h That section does not include drivers/net/wireless/ I believe John Linville isn't maintaining all the wireless drivers, he's acting as a gatekeeper in a similar role as DavidM for drivers/net/. The patch above means scripts/get_maintainer.pl can use the linux-wireless@vger list email address for any change in driver/net/wireless/ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:27 ` Joe Perches @ 2009-07-28 18:34 ` David Miller 0 siblings, 0 replies; 11+ messages in thread From: David Miller @ 2009-07-28 18:34 UTC (permalink / raw) To: joe Cc: randy.dunlap, linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless From: Joe Perches <joe@perches.com> Date: Tue, 28 Jul 2009 11:27:07 -0700 > On Tue, 2009-07-28 at 11:15 -0700, Randy Dunlap wrote: >> On Tue, 28 Jul 2009 11:06:37 -0700 Joe Perches wrote: >> > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: >> > > Wireless patches need to be CC:'d to linux-wireless so that >> > > John Linville can notice and pick them up >> > Signed-off-by: Joe Perches <joe@perches.com> >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index ebc2691..0574aad 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -4186,6 +4186,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git >> > S: Odd Fixes >> > F: drivers/net/ >> > >> > +NETWORKING WIRELESS DRIVERS >> > +L: linux-wireless@vger.kernel.org >> > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git >> > +S: Odd Fixes >> > +F: drivers/net/wireless/ >> > + >> >> Already have this: >> >> NETWORKING [WIRELESS] >> P: John W. Linville >> M: linville@tuxdriver.com >> L: linux-wireless@vger.kernel.org >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git >> S: Maintained >> F: net/wireless/ >> F: include/net/ieee80211* >> F: include/linux/wireless.h > > That section does not include drivers/net/wireless/ So just add it. > I believe John Linville isn't maintaining all the > wireless drivers, he's acting as a gatekeeper in > a similar role as DavidM for drivers/net/. It still needs to hit his inbox and linux-wireless regardless. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:06 ` [PATCH] MAINTAINERS: Add networking wireless drivers section Joe Perches 2009-07-28 18:15 ` Randy Dunlap @ 2009-07-28 18:33 ` David Miller 2009-07-28 18:48 ` Joe Perches 2009-07-28 21:33 ` Johannes Berg 1 sibling, 2 replies; 11+ messages in thread From: David Miller @ 2009-07-28 18:33 UTC (permalink / raw) To: joe Cc: linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless From: Joe Perches <joe@perches.com> Date: Tue, 28 Jul 2009 11:06:37 -0700 > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: >> Wireless patches need to be CC:'d to linux-wireless so that >> John Linville can notice and pick them up > > Signed-off-by: Joe Perches <joe@perches.com> Why not just create a plain "WIRELESS" umbrella entry that contains all of drivers/net/wireless, net/mac80211, and net/wireless? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:33 ` David Miller @ 2009-07-28 18:48 ` Joe Perches 2009-08-11 13:55 ` Jiri Kosina 2009-07-28 21:33 ` Johannes Berg 1 sibling, 1 reply; 11+ messages in thread From: Joe Perches @ 2009-07-28 18:48 UTC (permalink / raw) To: David Miller Cc: linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, 2009-07-28 at 11:33 -0700, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Tue, 28 Jul 2009 11:06:37 -0700 > > > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: > >> Wireless patches need to be CC:'d to linux-wireless so that > >> John Linville can notice and pick them up > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Why not just create a plain "WIRELESS" umbrella entry > that contains all of drivers/net/wireless, net/mac80211, > and net/wireless? Whatever works for John I suppose. John, do you have a preference? I was trying to avoid the "S: Maintained" label and was copying the form of this section: NETWORKING DRIVERS L: netdev@vger.kernel.org W: http://www.linuxfoundation.org/en/Net T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git S: Odd Fixes F: drivers/net/ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:48 ` Joe Perches @ 2009-08-11 13:55 ` Jiri Kosina 2009-08-11 14:49 ` David Miller 0 siblings, 1 reply; 11+ messages in thread From: Jiri Kosina @ 2009-08-11 13:55 UTC (permalink / raw) To: Joe Perches Cc: David Miller, linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless On Tue, 28 Jul 2009, Joe Perches wrote: > > Why not just create a plain "WIRELESS" umbrella entry that contains > > all of drivers/net/wireless, net/mac80211, and net/wireless? > Whatever works for John I suppose. John, do you have a preference? > I was trying to avoid the "S: Maintained" label > and was copying the form of this section: > > NETWORKING DRIVERS > L: netdev@vger.kernel.org > W: http://www.linuxfoundation.org/en/Net > T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git > S: Odd Fixes > F: drivers/net/ Just out of curiosity, why is drivers/net marked as "Odd fixes" and not "Maintained"? -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-08-11 13:55 ` Jiri Kosina @ 2009-08-11 14:49 ` David Miller 0 siblings, 0 replies; 11+ messages in thread From: David Miller @ 2009-08-11 14:49 UTC (permalink / raw) To: jkosina Cc: joe, linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless From: Jiri Kosina <jkosina@suse.cz> Date: Tue, 11 Aug 2009 15:55:46 +0200 (CEST) > On Tue, 28 Jul 2009, Joe Perches wrote: > >> > Why not just create a plain "WIRELESS" umbrella entry that contains >> > all of drivers/net/wireless, net/mac80211, and net/wireless? >> Whatever works for John I suppose. John, do you have a preference? >> I was trying to avoid the "S: Maintained" label >> and was copying the form of this section: >> >> NETWORKING DRIVERS >> L: netdev@vger.kernel.org >> W: http://www.linuxfoundation.org/en/Net >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git >> S: Odd Fixes >> F: drivers/net/ > > Just out of curiosity, why is drivers/net marked as "Odd fixes" and not > "Maintained"? Because it depends upon the individual driver maintainers. For example, I don't think one could claim 3c515.c or other ISA ethernet drivers to be in any kind of "Maintained" state. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MAINTAINERS: Add networking wireless drivers section 2009-07-28 18:33 ` David Miller 2009-07-28 18:48 ` Joe Perches @ 2009-07-28 21:33 ` Johannes Berg 1 sibling, 0 replies; 11+ messages in thread From: Johannes Berg @ 2009-07-28 21:33 UTC (permalink / raw) To: David Miller Cc: joe, linville, julia, netdev, linux-kernel, kernel-janitors, linux-wireless [-- Attachment #1: Type: text/plain, Size: 662 bytes --] On Tue, 2009-07-28 at 11:33 -0700, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Tue, 28 Jul 2009 11:06:37 -0700 > > > On Tue, 2009-07-28 at 10:30 -0700, David Miller wrote: > >> Wireless patches need to be CC:'d to linux-wireless so that > >> John Linville can notice and pick them up > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Why not just create a plain "WIRELESS" umbrella entry > that contains all of drivers/net/wireless, net/mac80211, > and net/wireless? I'll happily maintain net/mac80211 and net/wireless, but won't be touching all the old crappy drivers/net/wireless with a long stick. johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-08-11 14:49 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <Pine.LNX.4.64.0907281753540.28189@ask.diku.dk> 2009-07-28 17:30 ` [PATCH 5/9] drivers/net/wireless: correct error-handling code David Miller 2009-07-28 17:52 ` John W. Linville 2009-07-28 18:06 ` [PATCH] MAINTAINERS: Add networking wireless drivers section Joe Perches 2009-07-28 18:15 ` Randy Dunlap 2009-07-28 18:27 ` Joe Perches 2009-07-28 18:34 ` David Miller 2009-07-28 18:33 ` David Miller 2009-07-28 18:48 ` Joe Perches 2009-08-11 13:55 ` Jiri Kosina 2009-08-11 14:49 ` David Miller 2009-07-28 21:33 ` Johannes Berg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).