From: Christian Lamparter <chunkeey@web.de>
To: Joerg Albert <jal2@gmx.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ar9170: cleanup of bss_info_changed and beacon config
Date: Wed, 5 Aug 2009 04:04:45 +0200 [thread overview]
Message-ID: <200908050404.47371.chunkeey@web.de> (raw)
In-Reply-To: <4A78CE98.70903@gmx.de>
On Wednesday 05 August 2009 02:13:12 Joerg Albert wrote:
> Enable/Disable the beacon in ar910_set_beacon_timers() independently
> of ar->vif, but controlled by BSS_CHANGED_BEACON_ENABLED and
> bss_conf->enable_beacon from mac80211.
no signed/cc here?
> ---
> drivers/net/wireless/ath/ar9170/ar9170.h | 1 +
> drivers/net/wireless/ath/ar9170/mac.c | 4 +++-
> drivers/net/wireless/ath/ar9170/main.c | 15 ++++++++-------
> 3 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ar9170/mac.c b/drivers/net/wireless/ath/ar9170/mac.c
> index d9f1f46..9f2801c 100644
> --- a/drivers/net/wireless/ath/ar9170/mac.c
> +++ b/drivers/net/wireless/ath/ar9170/mac.c
> @@ -388,7 +388,9 @@ int ar9170_set_beacon_timers(struct ar9170 *ar)
> u32 v = 0;
> u32 pretbtt = 0;
>
> - if (ar->vif) {
> + if (ar->enable_beacon) {
> + if (WARN_ON(!ar->vif))
> + return -ENODEV;
> v |= ar->vif->bss_conf.beacon_int;
>
> switch (ar->vif->type) {
err, guess that's why. (not fatal, but WARN)
the beacon timer isn't exclusively used to notify the driver when its
time for a new beacon... The STA mode uses the same _timer_
in reverse to wait for the next beacon form the assoc. AP.
that said: It does not look like the firmware implements anything
in this direction... But this is a clearly MAC register and there
could be something in the silicon which does something useful with
this information.
so, to be on the safe side: why not preserve the old behavior for the
STA mode as well and simply tell the hardware about dtim & beacon interval?
The only remaining question is where to disabled the timer for STA.
(which is in some way relevant to: [PATCH 2/2] because previously,
these timers were always disabled by remove_interface.)
I think the best place is in ar9170_op_bss_info_changed:
if (changed & BSS_CHANGED_ASSOC) {
just when bss_conf->assoc gets "0".
Regards,
Chr
next prev parent reply other threads:[~2009-08-05 2:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 0:13 [PATCH 1/2] ar9170: cleanup of bss_info_changed and beacon config Joerg Albert
2009-08-05 2:04 ` Christian Lamparter [this message]
2009-08-05 19:05 ` Joerg Albert
2009-08-05 20:25 ` Christian Lamparter
2009-08-07 14:42 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908050404.47371.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=jal2@gmx.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).