From: Christian Lamparter <chunkeey@web.de>
To: Joerg Albert <jal2@gmx.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ar9170: cleanup of bss_info_changed and beacon config
Date: Wed, 5 Aug 2009 22:25:14 +0200 [thread overview]
Message-ID: <200908052225.16114.chunkeey@web.de> (raw)
In-Reply-To: <4A79D7E5.1080604@gmx.de>
On Wednesday 05 August 2009 21:05:09 Joerg Albert wrote:
> On 08/05/2009 04:04 AM, Christian Lamparter wrote:
> > the beacon timer isn't exclusively used to notify the driver when its
> > time for a new beacon... The STA mode uses the same _timer_
> > in reverse to wait for the next beacon form the assoc. AP.
> >
> > so, to be on the safe side: why not preserve the old behavior for the
> > STA mode as well and simply tell the hardware about dtim & beacon interval?
>
> ar9170_set_beacon_timers() uses the beacon interval only if for AP mode,
Although pretbtt is closely related to the beacon interval.
It has a slightly different purpose: It fires _before_ the beacon is sent.
So the host is able to do some _last msec_ changes to the beacon.
> dtim is left in STA mode.
both dtim_period and beacon_int are ORed
|
| if (ar->vif) {
| v |= ar->vif->bss_conf.beacon_int;
| switch() [...]
| v |= ar->vif->bss_conf.dtim_period << 16;
| }
|
into AR9170_MAC_REG_BCN_PERIOD.
It would be a BUG if this setting is omitted in STA mode,
since dtim beacons are essential.
> > The only remaining question is where to disabled the timer for STA.
> > (which is in some way relevant to: [PATCH 2/2] because previously,
> > these timers were always disabled by remove_interface.)
> >
> > I think the best place is in ar9170_op_bss_info_changed:
> > if (changed & BSS_CHANGED_ASSOC) {
> >
> > just when bss_conf->assoc gets "0".
>
> Yes. IMHO also enable on bss_conf->assoc == 1.
yes, but not necessary for bss_conf->assoc == 1,
ieee80211_set_associated sets BSS_CHANGED_BEACON_INT.
ar9170_set_beacon_timers is executed twice unless
you throw more code at it than just the assoc check & call.
But anyway, that's fine by me.
Thanks,
Chr
next prev parent reply other threads:[~2009-08-05 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 0:13 [PATCH 1/2] ar9170: cleanup of bss_info_changed and beacon config Joerg Albert
2009-08-05 2:04 ` Christian Lamparter
2009-08-05 19:05 ` Joerg Albert
2009-08-05 20:25 ` Christian Lamparter [this message]
2009-08-07 14:42 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908052225.16114.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=jal2@gmx.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).