linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Brett Rudley <brudley@broadcom.com>,
	Henry Ptasinski <henryp@broadcom.com>,
	Dowan Kim <dowan@broadcom.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: brcm80211: brcmfmac: remove PCI SDIO controller binding
Date: Wed, 17 Nov 2010 13:10:35 -0800	[thread overview]
Message-ID: <20101117211035.GA2442@kroah.com> (raw)
In-Reply-To: <1289980726-28706-1-git-send-email-mike.rapoport@gmail.com>

On Wed, Nov 17, 2010 at 09:58:46AM +0200, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> ---
>  drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c |  229 ---------------------
>  1 files changed, 0 insertions(+), 229 deletions(-)

Wait, is this really ok code to be removing from the driver?

Brett and Henry, any objections to this?

Mike, why do you think this is ok to remove?  Is it because no one is
ever calling this even for both types of config for this driver?

thanks,

greg k-h

  reply	other threads:[~2010-11-17 21:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 11:36 [PATCH 0/4] staging: brcm80211: misc cleanups Mike Rapoport
2010-11-14 11:36 ` [PATCH 1/4] staging: brcm80211: remove unused osl_pkt{get,free}_static Mike Rapoport
2010-11-14 11:36 ` [PATCH 2/4] staging: brcm80211: brcmfmac: remove PCI SDIO controller binding Mike Rapoport
2010-11-16 20:04   ` Greg KH
2010-11-17  7:58     ` Mike Rapoport
2010-11-17 21:10       ` Greg KH [this message]
2010-11-17 22:00         ` Mike Rapoport
2010-11-17 22:11           ` Greg KH
2010-11-17 22:32             ` Brett Rudley
2010-11-18  7:39               ` Mike Rapoport
2010-11-18  7:39             ` Mike Rapoport
2010-11-14 11:36 ` [PATCH 3/4] staging: brcm80211: brcmfmac: remove PXA " Mike Rapoport
2010-11-14 11:36 ` [PATCH 4/4] staging: brcm80211: brcmfmac: cleanup bcmsdh_(un)register Mike Rapoport
2010-11-16 20:04   ` Greg KH
2010-11-17  8:00     ` Mike Rapoport
2010-11-17 21:11       ` Greg KH
2010-11-17 22:02         ` Mike Rapoport
2010-11-17 22:11           ` Greg KH
2010-11-19 19:27 ` [PATCH 0/4] staging: brcm80211: misc cleanups Brett Rudley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117211035.GA2442@kroah.com \
    --to=greg@kroah.com \
    --cc=brudley@broadcom.com \
    --cc=dowan@broadcom.com \
    --cc=gregkh@suse.de \
    --cc=henryp@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mike.rapoport@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).