From: Greg KH <gregkh@suse.de>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Greg KH <greg@kroah.com>, Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
Dowan Kim <dowan@broadcom.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: brcm80211: brcmfmac: cleanup bcmsdh_(un)register
Date: Wed, 17 Nov 2010 14:11:58 -0800 [thread overview]
Message-ID: <20101117221158.GC3851@suse.de> (raw)
In-Reply-To: <AANLkTikkVhc=3ismFX_5jWnzYHQiVXKbWQsFMPwTw6YZ@mail.gmail.com>
On Thu, Nov 18, 2010 at 12:02:15AM +0200, Mike Rapoport wrote:
> On Wed, Nov 17, 2010 at 11:11 PM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Nov 17, 2010 at 10:00:00AM +0200, Mike Rapoport wrote:
> >> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> >> ---
> >> drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c | 13 +------------
> >> 1 files changed, 1 insertions(+), 12 deletions(-)
> >>
> >> diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> index fd327e1..e3fb7ed 100644
> >> --- a/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> +++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> @@ -285,28 +285,17 @@ extern int sdio_function_init(void);
> >>
> >> int bcmsdh_register(bcmsdh_driver_t *driver)
> >> {
> >> - int error = 0;
> >> -
> >> drvinfo = *driver;
> >>
> >> -#if defined(BCMPLATFORM_BUS)
> >> -#if defined(BCMLXSDMMC)
> >> SDLX_MSG(("Linux Kernel SDIO/MMC Driver\n"));
> >> - error = sdio_function_init();
> >
> > Same question here, are you sure we can remove this code?
>
> I'm not removing sdio_function_init here. I've only replaced
> error = sdio_function_init();
> return error;
> with
> return sdio_function_init();
Doh, you are right, sorry about that, I missread the patch.
thanks
greg k-h
next prev parent reply other threads:[~2010-11-17 22:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 11:36 [PATCH 0/4] staging: brcm80211: misc cleanups Mike Rapoport
2010-11-14 11:36 ` [PATCH 1/4] staging: brcm80211: remove unused osl_pkt{get,free}_static Mike Rapoport
2010-11-14 11:36 ` [PATCH 2/4] staging: brcm80211: brcmfmac: remove PCI SDIO controller binding Mike Rapoport
2010-11-16 20:04 ` Greg KH
2010-11-17 7:58 ` Mike Rapoport
2010-11-17 21:10 ` Greg KH
2010-11-17 22:00 ` Mike Rapoport
2010-11-17 22:11 ` Greg KH
2010-11-17 22:32 ` Brett Rudley
2010-11-18 7:39 ` Mike Rapoport
2010-11-18 7:39 ` Mike Rapoport
2010-11-14 11:36 ` [PATCH 3/4] staging: brcm80211: brcmfmac: remove PXA " Mike Rapoport
2010-11-14 11:36 ` [PATCH 4/4] staging: brcm80211: brcmfmac: cleanup bcmsdh_(un)register Mike Rapoport
2010-11-16 20:04 ` Greg KH
2010-11-17 8:00 ` Mike Rapoport
2010-11-17 21:11 ` Greg KH
2010-11-17 22:02 ` Mike Rapoport
2010-11-17 22:11 ` Greg KH [this message]
2010-11-19 19:27 ` [PATCH 0/4] staging: brcm80211: misc cleanups Brett Rudley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117221158.GC3851@suse.de \
--to=gregkh@suse.de \
--cc=brudley@broadcom.com \
--cc=dowan@broadcom.com \
--cc=greg@kroah.com \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).