From: Rajkumar Manoharan <rmanoharan@atheros.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Rajkumar Manoharan <Rajkumar.Manoharan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <Jouni.Malinen@Atheros.com>
Subject: Re: [PATCH] ath9k: set hw opmode while changing interface type
Date: Wed, 12 Jan 2011 19:50:14 +0530 [thread overview]
Message-ID: <20110112142014.GA7350@vmraj-lnx.users.atheros.com> (raw)
In-Reply-To: <4D29F995.1000007@openwrt.org>
On Sun, Jan 09, 2011 at 11:38:21PM +0530, Felix Fietkau wrote:
> On 2011-01-09 9:51 AM, Rajkumar Manoharan wrote:
> > The commit "ath9k: Add change_interface callback" is
> > failed to set hw opmode while changing interface type
> > on runtime. Not setting opmode fails to generate
> > beacons on changing to AP mode.
> >
> I think since not only ah->opmode matters, but also various other things
> that conditionally enable/disable ANI, various flags in ah->imask, etc.
> it would probably be best to merge most of the code of .add_interface,
> .remove_interface and .change_interface into one function that iterates
> over all active interfaces and calculates all the mode dependent
> parameters. The way things are done right now is just too fragile.
Sorry for delayed response. Will send a RFC patch. Thanks for the review.
--
Rajkumar
prev parent reply other threads:[~2011-01-12 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 16:51 [PATCH] ath9k: set hw opmode while changing interface type Rajkumar Manoharan
2011-01-09 18:08 ` Felix Fietkau
2011-01-12 14:20 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112142014.GA7350@vmraj-lnx.users.atheros.com \
--to=rmanoharan@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Rajkumar.Manoharan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).