From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Jouni Malinen <Jouni.Malinen@Atheros.com>
Subject: Re: [PATCH] ath9k: set hw opmode while changing interface type
Date: Sun, 09 Jan 2011 11:08:21 -0700 [thread overview]
Message-ID: <4D29F995.1000007@openwrt.org> (raw)
In-Reply-To: <1294591888-16625-1-git-send-email-rmanoharan@atheros.com>
On 2011-01-09 9:51 AM, Rajkumar Manoharan wrote:
> The commit "ath9k: Add change_interface callback" is
> failed to set hw opmode while changing interface type
> on runtime. Not setting opmode fails to generate
> beacons on changing to AP mode.
>
> Cc: stable@kernel.org
> Cc: Jouni Malinen<Jouni.Malinen@Atheros.com>
> Signed-off-by: Rajkumar Manoharan<rmanoharan@atheros.com>
> ---
> drivers/net/wireless/ath/ath9k/beacon.c | 1 +
> drivers/net/wireless/ath/ath9k/main.c | 4 ++++
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
I'm really not convinced that this is enough. How about implementing
proper code for recalculating ah->opmode and doing hw resets when
necessary, instead of adding more band-aids that can only deal with
having only one interface. This patch really only fixes a few visible
parts of the problem, but in the details the ath9k_change_interface
callback still somewhat broken.
I think since not only ah->opmode matters, but also various other things
that conditionally enable/disable ANI, various flags in ah->imask, etc.
it would probably be best to merge most of the code of .add_interface,
.remove_interface and .change_interface into one function that iterates
over all active interfaces and calculates all the mode dependent
parameters. The way things are done right now is just too fragile.
- Felix
next prev parent reply other threads:[~2011-01-09 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 16:51 [PATCH] ath9k: set hw opmode while changing interface type Rajkumar Manoharan
2011-01-09 18:08 ` Felix Fietkau [this message]
2011-01-12 14:20 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D29F995.1000007@openwrt.org \
--to=nbd@openwrt.org \
--cc=Jouni.Malinen@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).