From: Paul Stewart <pstew@chromium.org>
To: linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: [PATCH] cfg80211: Ignore downstream DEAUTH for authtry_bsses
Date: Wed, 8 Jun 2011 05:52:52 -0700 [thread overview]
Message-ID: <20110609191327.20D2C2038D@glenhelen.mtv.corp.google.com> (raw)
If we receive a DEAUTH message from an AP while performing
an AUTH request, this does not constitute a reply to our AUTH
request. In some cases an incoming DEAUTH may be due to the AP
clearing out old state from a previous authentication.
Instead we should ignore it and continue waiting for an AUTH
response.
Signed-off-by: Paul Stewart <pstew@chromium.org>
---
net/wireless/mlme.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
index 493b939..3633ab6 100644
--- a/net/wireless/mlme.c
+++ b/net/wireless/mlme.c
@@ -170,7 +170,9 @@ void __cfg80211_send_deauth(struct net_device *dev,
break;
}
if (wdev->authtry_bsses[i] &&
- memcmp(wdev->authtry_bsses[i]->pub.bssid, bssid, ETH_ALEN) == 0) {
+ memcmp(wdev->authtry_bsses[i]->pub.bssid, bssid,
+ ETH_ALEN) == 0 &&
+ memcmp(mgmt->sa, dev->dev_addr, ETH_ALEN) == 0) {
cfg80211_unhold_bss(wdev->authtry_bsses[i]);
cfg80211_put_bss(&wdev->authtry_bsses[i]->pub);
wdev->authtry_bsses[i] = NULL;
--
1.7.3.1
next reply other threads:[~2011-06-09 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 12:52 Paul Stewart [this message]
2011-06-09 19:17 ` [PATCH] cfg80211: Ignore downstream DEAUTH for authtry_bsses Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2011-06-06 23:00 [RFC] cfg80211: Fix handling of previous_auth deauth Paul Stewart
2011-06-08 11:02 ` Johannes Berg
[not found] ` <BANLkTimdAHt9VUUmNB2uzgm8ymeo6J+EeA@mail.gmail.com>
2011-06-08 11:44 ` Johannes Berg
2011-06-08 11:48 ` Paul Stewart
2011-06-08 11:50 ` Johannes Berg
2011-06-08 12:52 ` [PATCH] cfg80211: Ignore downstream DEAUTH for authtry_bsses Paul Stewart
2011-06-08 13:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609191327.20D2C2038D@glenhelen.mtv.corp.google.com \
--to=pstew@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).