[PATCH] NFC: microread: use kfree_skb() instead of kfree()

[PATCH] NFC: microread: use kfree_skb() instead of kfree()

[Wei Yongjun]

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Use kfree_skb() instead of kfree() to free sk_buff.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/nfc/microread/mei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index eef38cf..da8264c 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -130,7 +130,7 @@ static void microread_event_cb(struct mei_device *device, u32 events,
 
 		reply_size = mei_recv(device, skb->data, MEI_NFC_MAX_READ);
 		if (reply_size < MEI_NFC_HEADER_SIZE) {
-			kfree(skb);
+			kfree_skb(skb);
 			return;
 		}
 

Re: [linux-nfc] [PATCH] NFC: microread: use kfree_skb() instead of kfree()

[Rymarkiewicz Waldemar]

Hi,

> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>   drivers/nfc/microread/mei.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
> index eef38cf..da8264c 100644
> --- a/drivers/nfc/microread/mei.c
> +++ b/drivers/nfc/microread/mei.c
> @@ -130,7 +130,7 @@ static void microread_event_cb(struct mei_device *device, u32 events,
>
>   		reply_size = mei_recv(device, skb->data, MEI_NFC_MAX_READ);
>   		if (reply_size < MEI_NFC_HEADER_SIZE) {
> -			kfree(skb);
> +			kfree_skb(skb);
>   			return;
>   		}

kfree_skb call is used internally by the kernel. A driver should use 
dev_kfree_skb instead, I guess.

Thanks,
/Waldek

Re: [linux-nfc] [PATCH] NFC: microread: use kfree_skb() instead of kfree()

[Wei Yongjun]

On 03/21/2013 07:37 PM, Rymarkiewicz Waldemar wrote:
> Hi,
>
>> Use kfree_skb() instead of kfree() to free sk_buff.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> ---
>>   drivers/nfc/microread/mei.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
>> index eef38cf..da8264c 100644
>> --- a/drivers/nfc/microread/mei.c
>> +++ b/drivers/nfc/microread/mei.c
>> @@ -130,7 +130,7 @@ static void microread_event_cb(struct mei_device *device, u32 events,
>>
>>           reply_size = mei_recv(device, skb->data, MEI_NFC_MAX_READ);
>>           if (reply_size < MEI_NFC_HEADER_SIZE) {
>> -            kfree(skb);
>> +            kfree_skb(skb);
>>               return;
>>           }
>
> kfree_skb call is used internally by the kernel. A driver should use dev_kfree_skb instead, I guess.

It seems that dev_kfree_skb() call when dev_alloc_skb() is used, and
kfree_skb() use to free skb malloced by alloc_skb().

Regards,
Yongjun Wei 

Re: [linux-nfc] [PATCH] NFC: microread: use kfree_skb() instead of kfree()

[Rymarkiewicz Waldemar]

Hi,

>>
>> kfree_skb call is used internally by the kernel. A driver should use dev_kfree_skb instead, I guess.
>
> It seems that dev_kfree_skb() call when dev_alloc_skb() is used, and
> kfree_skb() use to free skb malloced by alloc_skb().

I agree. The driver should use  dev_* flavoured skb function then.


Thanks,
/Waldek

Re: [linux-nfc] [PATCH] NFC: microread: use kfree_skb() instead of kfree()

[Samuel Ortiz]

Hi Waldemar,

On Fri, Mar 22, 2013 at 11:38:57AM +0100, Rymarkiewicz Waldemar wrote:
> Hi,
> 
> >>
> >>kfree_skb call is used internally by the kernel. A driver should use dev_kfree_skb instead, I guess.
> >
> >It seems that dev_kfree_skb() call when dev_alloc_skb() is used, and
> >kfree_skb() use to free skb malloced by alloc_skb().
> 
> I agree. The driver should use  dev_* flavoured skb function then.
I'd prefer the driver to call nfc_alloc_recv_skb() instead. This one calls
alloc_skb() but we could have it call dev_alloc_skb() I suppose. dev_alloc_skb
does atomic allocation though.
And kfree_skb() or dev_kfree_skb() is essentially the same.

I'll fix the driver so that it calls nfc_alloc_recv_skb() and kfree_skb unless
Wei beats me at it.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/