From: Henrik Austad <henrik@austad.us>
To: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: Emmanuel Grumbach <egrumbach@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 00/10] make iwlwifi RT friendly
Date: Tue, 17 Dec 2013 10:43:25 +0100 [thread overview]
Message-ID: <20131217094325.GA2413@austad.us> (raw)
In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB303D2233A@HASMSX103.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
On Tue, Dec 17, 2013 at 09:32:14AM +0000, Grumbach, Emmanuel wrote:
> >
> > On Sun, Dec 15, 2013 at 07:50:23PM +0200, Emmanuel Grumbach wrote:
> > >
> > >
> > > On 12/15/2013 07:46 PM, Sebastian Andrzej Siewior wrote:
> > > > On 12/15/2013 06:45 PM, Emmanuel Grumbach wrote:
> > > >> No we don't. The primary interrupt just tells the hardware to stop
> > > >> firing interrupts and wakes up the thread as written above.
> > > >
> > > > Sounds great then.
> > > >
> > >
> > > Ok - I guess I'll submit then internally then before we send them upstream.
> >
> > I'm trying to mash this on top of 3.12.5 for the latest rt-release, and especially
> > drivers/net/wireless/iwlwifi/pcie/rx.c is not particularly compatible with your
> > patches, especially iwl_pcie_int_cause_non_ict(), which as been moved,
> > renamed and given new return values.
>
> iwl_pcie_int_cause_non_ict didn't exist before my patch. I am not sure I follow here...
bah, git is messing with my head, iwl_pcie_is_non_ict() used a lot of the
same code as iwl_pcie_isr(), so I mistakenly saw it as a rename (which got
me a bit confused). Looking closer and applying enough braincells to form a
synapse, I see that it has just moved further down.
> I am not sure I'll have the time to fulfill your request, but I'll try.
Fair enough, I'll give the rt-port of the patches another go :)
--
Henrik Austad
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2013-12-17 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:33 [RFC 00/10] make iwlwifi RT friendly Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 01/10] iwlwifi: pcie: clean up ICT allocation code Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 02/10] iwlwifi: pcie: track interrupt mask in SW Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 03/10] iwlwifi: pcie: re-organize the PCIe ISR code Emmanuel Grumbach
2013-12-11 9:49 ` Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 04/10] iwlwifi: pcie: move the ICT / non-ICT handling functions Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 05/10] iwlwifi: pcie: read the interrupt cause from the handler Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 06/10] iwlwifi: pcie: determine the interrupt type in " Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 07/10] iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ict Emmanuel Grumbach
2013-12-11 8:33 ` Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 08/10] iwlwifi: pcie: no need to save inta in trans_pcie Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 09/10] iwlwifi: pcie: move interrupt prints to the common handler Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 10/10] iwlwifi: pcie: stop using _irqsave Emmanuel Grumbach
2013-12-11 11:17 ` [RFC 00/10] make iwlwifi RT friendly Emmanuel Grumbach
2013-12-15 15:48 ` Sebastian Andrzej Siewior
2013-12-15 17:45 ` Emmanuel Grumbach
2013-12-15 17:46 ` Sebastian Andrzej Siewior
2013-12-15 17:50 ` Emmanuel Grumbach
2013-12-17 9:21 ` Henrik Austad
2013-12-17 9:32 ` Grumbach, Emmanuel
2013-12-17 9:43 ` Henrik Austad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217094325.GA2413@austad.us \
--to=henrik@austad.us \
--cc=bigeasy@linutronix.de \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).