From: Emmanuel Grumbach <egrumbach@gmail.com>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-rt-users@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 00/10] make iwlwifi RT friendly
Date: Wed, 11 Dec 2013 13:17:04 +0200 [thread overview]
Message-ID: <CANUX_P3g_WFvpiUZi9h1MKbHRcDtTdrLjem6n0mSf9wwv_+UwA@mail.gmail.com> (raw)
In-Reply-To: <1386750826-25219-1-git-send-email-emmanuel.grumbach@intel.com>
On Wed, Dec 11, 2013 at 10:33 AM, Emmanuel Grumbach
<emmanuel.grumbach@intel.com> wrote:
> RT folks have raised issues with iwlwifi wrt. RT kernel some time
> ago. Johannes had a few patches to address this, but I had a few
> concerns with them. This series tries to address the RT concerns:
> * we don't do anything in hard-irq context besides stopping the
> interrupts in the device.
> * the interrupt cause is read from the irq handler and is handled
> there.
>
Well - this was a bit unfair :)
The code I get is probably very similar (and inspired) from Johannes's
work. But I guess I was missing:
iwlwifi: pcie: track interrupt mask in SW.
> This allows us to avoid the usage of _irqsave all over the driver
> and also avoids any kind of locks in the hard-irq context.
> We still have some work to do with the locks in the handler.
> I believe the locking model can be improved there.
>
> This patch series is split is very small patches. While this can
> annoy the reader - it helped me much to make sure I don't do anything
> wrong (well - I am still not sure) - and IMHO, it makes the review easier.
> For example, in patch
> iwlwifi: pcie: move the ICT / non-ICT handling functions
> I just copy code from place to place without changing a bit. This makes
> the significant diff smaller.
>
> Emmanuel Grumbach (10):
> iwlwifi: pcie: clean up ICT allocation code
> iwlwifi: pcie: track interrupt mask in SW
> iwlwifi: pcie: re-organize the PCIe ISR code
> iwlwifi: pcie: move the ICT / non-ICT handling functions
> iwlwifi: pcie: read the interrupt cause from the handler
> iwlwifi: pcie: determine the interrupt type in the handler
> iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ict
> iwlwifi: pcie: no need to save inta in trans_pcie
> iwlwifi: pcie: move interrupt prints to the common handler
> iwlwifi: pcie: stop using _irqsave
>
> drivers/net/wireless/iwlwifi/iwl-csr.h | 3 +-
> drivers/net/wireless/iwlwifi/pcie/internal.h | 9 +-
> drivers/net/wireless/iwlwifi/pcie/rx.c | 389 +++++++++++----------------
> drivers/net/wireless/iwlwifi/pcie/trans.c | 27 +-
> drivers/net/wireless/iwlwifi/pcie/tx.c | 10 +-
> 5 files changed, 185 insertions(+), 253 deletions(-)
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-11 11:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:33 [RFC 00/10] make iwlwifi RT friendly Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 01/10] iwlwifi: pcie: clean up ICT allocation code Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 02/10] iwlwifi: pcie: track interrupt mask in SW Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 03/10] iwlwifi: pcie: re-organize the PCIe ISR code Emmanuel Grumbach
2013-12-11 9:49 ` Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 04/10] iwlwifi: pcie: move the ICT / non-ICT handling functions Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 05/10] iwlwifi: pcie: read the interrupt cause from the handler Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 06/10] iwlwifi: pcie: determine the interrupt type in " Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 07/10] iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ict Emmanuel Grumbach
2013-12-11 8:33 ` Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 08/10] iwlwifi: pcie: no need to save inta in trans_pcie Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 09/10] iwlwifi: pcie: move interrupt prints to the common handler Emmanuel Grumbach
2013-12-11 8:33 ` [RFC 10/10] iwlwifi: pcie: stop using _irqsave Emmanuel Grumbach
2013-12-11 11:17 ` Emmanuel Grumbach [this message]
2013-12-15 15:48 ` [RFC 00/10] make iwlwifi RT friendly Sebastian Andrzej Siewior
2013-12-15 17:45 ` Emmanuel Grumbach
2013-12-15 17:46 ` Sebastian Andrzej Siewior
2013-12-15 17:50 ` Emmanuel Grumbach
2013-12-17 9:21 ` Henrik Austad
2013-12-17 9:32 ` Grumbach, Emmanuel
2013-12-17 9:43 ` Henrik Austad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANUX_P3g_WFvpiUZi9h1MKbHRcDtTdrLjem6n0mSf9wwv_+UwA@mail.gmail.com \
--to=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).