[PATCH] b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

[PATCH] b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

[Rafał Miłecki]

These are extra configs specific to the SSB. Lack of this dependency and
CONFIG_B43=y
CONFIG_B43_BUSES_BCMA=y
CONFIG_SSB=m
would result in:
> drivers/built-in.o: In function `b43_sdio_remove':
> sdio.c:(.text+0x14657f): undefined reference to `ssb_bus_unregister'
> drivers/built-in.o: In function `b43_sdio_probe':
> sdio.c:(.text+0x14672f): undefined reference to `ssb_bus_sdiobus_register'

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/net/wireless/b43/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/b43/Kconfig b/drivers/net/wireless/b43/Kconfig
index 1c7d27b..e3f67b8 100644
--- a/drivers/net/wireless/b43/Kconfig
+++ b/drivers/net/wireless/b43/Kconfig
@@ -73,7 +73,7 @@ config B43_PCICORE_AUTOSELECT
 
 config B43_PCMCIA
 	bool "Broadcom 43xx PCMCIA device support"
-	depends on B43 && SSB_PCMCIAHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_PCMCIAHOST_POSSIBLE
 	select SSB_PCMCIAHOST
 	---help---
 	  Broadcom 43xx PCMCIA device support.
@@ -93,7 +93,7 @@ config B43_PCMCIA
 
 config B43_SDIO
 	bool "Broadcom 43xx SDIO device support"
-	depends on B43 && SSB_SDIOHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_SDIOHOST_POSSIBLE
 	select SSB_SDIOHOST
 	---help---
 	  Broadcom 43xx device support for Soft-MAC SDIO devices.
-- 
1.8.4.5

Re: [PATCH] b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

[Michael Büsch]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Sun, 18 May 2014 13:41:33 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

>  config B43_PCMCIA
>  	bool "Broadcom 43xx PCMCIA device support"
> -	depends on B43 && SSB_PCMCIAHOST_POSSIBLE
> +	depends on B43 && B43_SSB && SSB_PCMCIAHOST_POSSIBLE
>  	select SSB_PCMCIAHOST
>  	---help---
>  	  Broadcom 43xx PCMCIA device support.
> @@ -93,7 +93,7 @@ config B43_PCMCIA
>  
>  config B43_SDIO
>  	bool "Broadcom 43xx SDIO device support"
> -	depends on B43 && SSB_SDIOHOST_POSSIBLE
> +	depends on B43 && B43_SSB && SSB_SDIOHOST_POSSIBLE
>  	select SSB_SDIOHOST
>  	---help---
>  	  Broadcom 43xx device support for Soft-MAC SDIO devices.

This makes sense.
Ack by me.


-- 
Michael.

----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]