From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: andy.shevchenko@gmail.com, motobud@gmail.com
Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath6kl@lists.infradead.org
Subject: Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method
Date: Sun, 29 Nov 2015 11:56:41 +0900 [thread overview]
Message-ID: <201511291156.IJG90618.VFOQSHFOMOFtJL@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <CAHp75VcVdMNrxvedCB_OmJw7upTPJq8T8tKxfBn_moYGj6S19g@mail.gmail.com>
Andy Shevchenko wrote:
> On Sat, Nov 28, 2015 at 8:58 PM, Brent Taylor <motobud@gmail.com> wrote:
> > Whats the status on this patch? I don't see it on patchwork anymore
> > nor is it in any of the git trees I checked.
> >
>
> You forget to use kvfree() instead of kfree() in core.c.
>
In addition to that, I think you can do like below.
if (&ar->fw == fw)
*fw = vmalloc(fw_entry->size);
else
*fw = kmalloc(fw_entry->size, GFP_KERNEL);
if (*fw == NULL)
ret = -ENOMEM;
else
memcpy(*fw, fw_entry->data, fw_entry->size);
next prev parent reply other threads:[~2015-11-29 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 5:10 [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method Brent Taylor
2015-11-28 18:58 ` Brent Taylor
2015-11-29 0:53 ` Andy Shevchenko
2015-11-29 2:56 ` Tetsuo Handa [this message]
2015-11-29 5:13 ` [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Brent Taylor
2015-11-29 5:27 ` kbuild test robot
2015-11-29 5:51 ` [PATCH v3] " Brent Taylor
2015-11-30 8:48 ` Kalle Valo
2015-11-30 8:48 ` [PATCH v2] " Kalle Valo
2015-11-30 9:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511291156.IJG90618.VFOQSHFOMOFtJL@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=andy.shevchenko@gmail.com \
--cc=ath6kl@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=motobud@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).