From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Brent Taylor <motobud@gmail.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ath6kl@lists.infradead.org>
Subject: Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree
Date: Mon, 30 Nov 2015 11:05:52 +0200 [thread overview]
Message-ID: <87mvtvluvj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87zixvlvp8.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 30 Nov 2015 10:48:03 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Brent Taylor <motobud@gmail.com> writes:
>
>> Signed-off-by: Brent Taylor <motobud@gmail.com>
>>
>> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree
>> ---
>> Changes v1 -> v2:
>> - simplify memory allocation
>> - use kvfree
>
> Why? The commit log should _always_ answer that. Are you fixing a bug
> (what bug exactly?), is this just cleanup or what?
>
> And the commit log is wrongly formatted anyway, the Signed-off-by line
> should be the last and there should be no "ath6kl:" string in the commit
> log (just in the title). Use 'git log' to find examples.
Fixing netdev address (kenrel -> kernel)
--
Kalle Valo
prev parent reply other threads:[~2015-11-30 9:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 5:10 [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method Brent Taylor
2015-11-28 18:58 ` Brent Taylor
2015-11-29 0:53 ` Andy Shevchenko
2015-11-29 2:56 ` Tetsuo Handa
2015-11-29 5:13 ` [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Brent Taylor
2015-11-29 5:27 ` kbuild test robot
2015-11-29 5:51 ` [PATCH v3] " Brent Taylor
2015-11-30 8:48 ` Kalle Valo
2015-11-30 8:48 ` [PATCH v2] " Kalle Valo
2015-11-30 9:05 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvtvluvj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=motobud@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).