* [PATCH] libertas: Fix lbs_prb_rsp_limit_set()
@ 2017-06-23 15:17 Dan Carpenter
2017-06-23 20:22 ` James Cameron
2017-06-28 18:18 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-06-23 15:17 UTC (permalink / raw)
To: Kalle Valo, Jingoo Han; +Cc: libertas-dev, linux-wireless, kernel-janitors
The kstrtoul() test was reversed so this always returned -ENOTSUPP.
Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
index eeeb892219aa..37ace5cb309d 100644
--- a/drivers/net/wireless/marvell/libertas/mesh.c
+++ b/drivers/net/wireless/marvell/libertas/mesh.c
@@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
memset(&mesh_access, 0, sizeof(mesh_access));
mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
- if (!kstrtoul(buf, 10, &retry_limit))
- return -ENOTSUPP;
+ ret = kstrtoul(buf, 10, &retry_limit);
+ if (ret)
+ return ret;
if (retry_limit > 15)
return -ENOTSUPP;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libertas: Fix lbs_prb_rsp_limit_set()
2017-06-23 15:17 [PATCH] libertas: Fix lbs_prb_rsp_limit_set() Dan Carpenter
@ 2017-06-23 20:22 ` James Cameron
2017-06-28 18:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: James Cameron @ 2017-06-23 20:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kalle Valo, Jingoo Han, kernel-janitors, linux-wireless, libertas-dev
On Fri, Jun 23, 2017 at 06:17:38PM +0300, Dan Carpenter wrote:
> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
>
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: James Cameron <quozl@laptop.org>
--
James Cameron
http://quozl.netrek.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libertas: Fix lbs_prb_rsp_limit_set()
2017-06-23 15:17 [PATCH] libertas: Fix lbs_prb_rsp_limit_set() Dan Carpenter
2017-06-23 20:22 ` James Cameron
@ 2017-06-28 18:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-06-28 18:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jingoo Han, libertas-dev, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
>
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: James Cameron <quozl@laptop.org>
>
> diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
> index eeeb892219aa..37ace5cb309d 100644
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
> memset(&mesh_access, 0, sizeof(mesh_access));
> mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
>
> - if (!kstrtoul(buf, 10, &retry_limit))
> - return -ENOTSUPP;
> + ret = kstrtoul(buf, 10, &retry_limit);
> + if (ret)
> + return ret;
> if (retry_limit > 15)
> return -ENOTSUPP;
Patch applied to wireless-drivers-next.git, thanks.
69551f5f370c libertas: Fix lbs_prb_rsp_limit_set()
--
https://patchwork.kernel.org/patch/9806775/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-28 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 15:17 [PATCH] libertas: Fix lbs_prb_rsp_limit_set() Dan Carpenter
2017-06-23 20:22 ` James Cameron
2017-06-28 18:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).