* [PATCH for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices
@ 2017-08-11 10:07 Arend van Spriel
2017-08-11 10:30 ` Kalle Valo
2017-08-14 8:09 ` [for-4.13] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Arend van Spriel @ 2017-08-11 10:07 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Arend van Spriel
The firmware feature check introduced for multi-scheduled scan turned out
to be failing for bcm4343{0,1,8} devices resulting in a firmware crash.
The reason for this crash has not yet been root cause so this patch avoids
the feature check for those device as a short-term fix.
Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
Reported-by: Ian Molton <ian@mnementh.co.uk>
Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index d21258d..f1b60740e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -159,8 +159,10 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
brcmf_feat_firmware_capabilities(ifp);
memset(&gscan_cfg, 0, sizeof(gscan_cfg));
- brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg",
- &gscan_cfg, sizeof(gscan_cfg));
+ if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID)
+ brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN,
+ "pfn_gscan_cfg",
+ &gscan_cfg, sizeof(gscan_cfg));
brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn");
if (drvr->bus_if->wowl_supported)
brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices
2017-08-11 10:07 [PATCH for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices Arend van Spriel
@ 2017-08-11 10:30 ` Kalle Valo
2017-08-14 8:09 ` [for-4.13] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-08-11 10:30 UTC (permalink / raw)
To: Arend van Spriel; +Cc: linux-wireless
Arend van Spriel <arend.vanspriel@broadcom.com> writes:
> The firmware feature check introduced for multi-scheduled scan turned out
> to be failing for bcm4343{0,1,8} devices resulting in a firmware crash.
> The reason for this crash has not yet been root cause so this patch avoids
> the feature check for those device as a short-term fix.
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reported-by: Ian Molton <ian@mnementh.co.uk>
> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
So the first release for 9fe929aaace6 was v4.13-rc1 so no stable tag
needed.
(This is mostly to remind myself about this :)
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices
2017-08-11 10:07 [PATCH for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices Arend van Spriel
2017-08-11 10:30 ` Kalle Valo
@ 2017-08-14 8:09 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-08-14 8:09 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: linux-wireless, Arend van Spriel
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> The firmware feature check introduced for multi-scheduled scan turned out
> to be failing for bcm4343{0,1,8} devices resulting in a firmware crash.
> The reason for this crash has not yet been root cause so this patch avoids
> the feature check for those device as a short-term fix.
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reported-by: Ian Molton <ian@mnementh.co.uk>
> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers.git, thanks.
e9bf53ab1ee3 brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices
--
https://patchwork.kernel.org/patch/9895411/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-11 10:07 [PATCH for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices Arend van Spriel
2017-08-11 10:30 ` Kalle Valo
2017-08-14 8:09 ` [for-4.13] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).