* [PATCH] mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx()
@ 2018-03-17 11:29 Lorenzo Bianconi
2018-03-17 21:03 ` Felix Fietkau
2018-03-27 9:11 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2018-03-17 11:29 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless
Fix a theoretical NULL pointer dereferencing in mt76x2_tx routine that
can occurs for injected frames in a monitor vif since vif pointer could
be NULL for that interfaces
Fixes: 23405236460b ("mt76: fix transmission of encrypted mgmt frames")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_tx.c b/drivers/net/wireless/mediatek/mt76/mt76x2_tx.c
index 534e4bf9a34c..e46eafc4c436 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_tx.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_tx.c
@@ -36,9 +36,12 @@ void mt76x2_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control,
msta = (struct mt76x2_sta *) control->sta->drv_priv;
wcid = &msta->wcid;
+ /* sw encrypted frames */
+ if (!info->control.hw_key && wcid->hw_key_idx != -1)
+ control->sta = NULL;
}
- if (vif || (!info->control.hw_key && wcid->hw_key_idx != -1)) {
+ if (vif && !control->sta) {
struct mt76x2_vif *mvif;
mvif = (struct mt76x2_vif *) vif->drv_priv;
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx()
2018-03-17 11:29 [PATCH] mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx() Lorenzo Bianconi
@ 2018-03-17 21:03 ` Felix Fietkau
2018-03-27 9:11 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2018-03-17 21:03 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless
On 2018-03-17 12:29, Lorenzo Bianconi wrote:
> Fix a theoretical NULL pointer dereferencing in mt76x2_tx routine that
> can occurs for injected frames in a monitor vif since vif pointer could
> be NULL for that interfaces
>
> Fixes: 23405236460b ("mt76: fix transmission of encrypted mgmt frames")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx()
2018-03-17 11:29 [PATCH] mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx() Lorenzo Bianconi
2018-03-17 21:03 ` Felix Fietkau
@ 2018-03-27 9:11 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-03-27 9:11 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Fix a theoretical NULL pointer dereferencing in mt76x2_tx routine that
> can occurs for injected frames in a monitor vif since vif pointer could
> be NULL for that interfaces
>
> Fixes: 23405236460b ("mt76: fix transmission of encrypted mgmt frames")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers-next.git, thanks.
6958b027435a mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx()
--
https://patchwork.kernel.org/patch/10290771/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-27 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-17 11:29 [PATCH] mt76x2: fix possible NULL pointer dereferencing in mt76x2_tx() Lorenzo Bianconi
2018-03-17 21:03 ` Felix Fietkau
2018-03-27 9:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).