* [PATCH] b43: Fix regression in kernel 4.18
@ 2018-08-27 15:34 Larry Finger
2018-08-31 15:38 ` Kalle Valo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Larry Finger @ 2018-08-27 15:34 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger, Stable, Taketo Kabe
In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
a condition is noted where the network controller needs to be reset. Note
that this situation happens when running the open-source firmware
(http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special
conditions.
for a different card model, it is reported that this change breaks
operation running the proprietary firmware
(https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather
than reverting the previous patch, the code is tweaked to avoid the
reset unless the open-source firmware is being used.
Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched")
Cc: Stable <stable@vger.kernel.org> # 4.18+
Cc: Taketo Kabe <kabe@sra-tohoku.co.jp>
Reported-and-tested-by: D. Prabhu <d.praabhu@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/broadcom/b43/dma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c
index 6b0e1ec346cb..d46d57b989ae 100644
--- a/drivers/net/wireless/broadcom/b43/dma.c
+++ b/drivers/net/wireless/broadcom/b43/dma.c
@@ -1518,13 +1518,15 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev,
}
} else {
/* More than a single header/data pair were missed.
- * Report this error, and reset the controller to
+ * Report this error. If running with open-source
+ * firmware, then reset the controller to
* revive operation.
*/
b43dbg(dev->wl,
"Out of order TX status report on DMA ring %d. Expected %d, but got %d\n",
ring->index, firstused, slot);
- b43_controller_restart(dev, "Out of order TX");
+ if (dev->fw.opensource)
+ b43_controller_restart(dev, "Out of order TX");
return;
}
}
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] b43: Fix regression in kernel 4.18
2018-08-27 15:34 [PATCH] b43: Fix regression in kernel 4.18 Larry Finger
@ 2018-08-31 15:38 ` Kalle Valo
[not found] ` <20180831153808.DD4246049C@smtp.codeaurora.org>
2018-09-20 11:59 ` [PATCH] b43: fix DMA error related regression with proprietary firmware Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2018-08-31 15:38 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Stable, Taketo Kabe
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
> a condition is noted where the network controller needs to be reset. Note
> that this situation happens when running the open-source firmware
> (http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special
> conditions.
>
> for a different card model, it is reported that this change breaks
> operation running the proprietary firmware
> (https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather
> than reverting the previous patch, the code is tweaked to avoid the
> reset unless the open-source firmware is being used.
>
> Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched")
> Cc: Stable <stable@vger.kernel.org> # 4.18+
> Cc: Taketo Kabe <kabe@sra-tohoku.co.jp>
> Reported-and-tested-by: D. Prabhu <d.praabhu@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
I'll change the title to something more descriptive:
b43: fix DMA error related regression with proprietary firmware
Does that make sense?
--
https://patchwork.kernel.org/patch/10577379/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] b43: Fix regression in kernel 4.18
[not found] ` <20180831153808.DD4246049C@smtp.codeaurora.org>
@ 2018-08-31 16:15 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2018-08-31 16:15 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Stable, Taketo Kabe
On 08/31/2018 10:38 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
>> a condition is noted where the network controller needs to be reset. Note
>> that this situation happens when running the open-source firmware
>> (http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special
>> conditions.
>>
>> for a different card model, it is reported that this change breaks
>> operation running the proprietary firmware
>> (https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather
>> than reverting the previous patch, the code is tweaked to avoid the
>> reset unless the open-source firmware is being used.
>>
>> Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched")
>> Cc: Stable <stable@vger.kernel.org> # 4.18+
>> Cc: Taketo Kabe <kabe@sra-tohoku.co.jp>
>> Reported-and-tested-by: D. Prabhu <d.praabhu@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> I'll change the title to something more descriptive:
>
> b43: fix DMA error related regression with proprietary firmware
>
> Does that make sense?
Yes, that is fine.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] b43: fix DMA error related regression with proprietary firmware
2018-08-27 15:34 [PATCH] b43: Fix regression in kernel 4.18 Larry Finger
2018-08-31 15:38 ` Kalle Valo
[not found] ` <20180831153808.DD4246049C@smtp.codeaurora.org>
@ 2018-09-20 11:59 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2018-09-20 11:59 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Stable, Taketo Kabe
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
> a condition is noted where the network controller needs to be reset. Note
> that this situation happens when running the open-source firmware
> (http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special
> conditions.
>
> for a different card model, it is reported that this change breaks
> operation running the proprietary firmware
> (https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather
> than reverting the previous patch, the code is tweaked to avoid the
> reset unless the open-source firmware is being used.
>
> Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched")
> Cc: Stable <stable@vger.kernel.org> # 4.18+
> Cc: Taketo Kabe <kabe@sra-tohoku.co.jp>
> Reported-and-tested-by: D. Prabhu <d.praabhu@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers.git, thanks.
2823c8716c68 b43: fix DMA error related regression with proprietary firmware
--
https://patchwork.kernel.org/patch/10577379/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-20 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 15:34 [PATCH] b43: Fix regression in kernel 4.18 Larry Finger
2018-08-31 15:38 ` Kalle Valo
[not found] ` <20180831153808.DD4246049C@smtp.codeaurora.org>
2018-08-31 16:15 ` Larry Finger
2018-09-20 11:59 ` [PATCH] b43: fix DMA error related regression with proprietary firmware Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).