* [PATCH] rtl818x: fix potential use after free
@ 2018-11-29 10:48 Pan Bian
2018-11-29 15:09 ` Larry Finger
2018-12-13 15:03 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2018-11-29 10:48 UTC (permalink / raw)
To: Herton Ronaldo Krzesinski, Hin-Tak Leung, Larry Finger,
Kalle Valo, David S. Miller
Cc: linux-wireless, netdev, linux-kernel, Pan Bian
entry is released via usb_put_urb just after calling usb_submit_urb.
However, entry is used if the submission fails, resulting in a use after
free bug. The patch fixes this.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
index cec3778..1a2ea8b 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
@@ -444,12 +444,13 @@ static int rtl8187_init_urbs(struct ieee80211_hw *dev)
skb_queue_tail(&priv->rx_queue, skb);
usb_anchor_urb(entry, &priv->anchored);
ret = usb_submit_urb(entry, GFP_KERNEL);
- usb_put_urb(entry);
if (ret) {
skb_unlink(skb, &priv->rx_queue);
usb_unanchor_urb(entry);
+ usb_put_urb(entry);
goto err;
}
+ usb_put_urb(entry);
}
return ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl818x: fix potential use after free
2018-11-29 10:48 [PATCH] rtl818x: fix potential use after free Pan Bian
@ 2018-11-29 15:09 ` Larry Finger
2018-12-13 15:03 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2018-11-29 15:09 UTC (permalink / raw)
To: Pan Bian, Herton Ronaldo Krzesinski, Hin-Tak Leung, Kalle Valo,
David S. Miller
Cc: linux-wireless, netdev, linux-kernel
On 11/29/18 4:48 AM, Pan Bian wrote:
> entry is released via usb_put_urb just after calling usb_submit_urb.
> However, entry is used if the submission fails, resulting in a use after
> free bug. The patch fixes this.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
> index cec3778..1a2ea8b 100644
> --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
> +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
> @@ -444,12 +444,13 @@ static int rtl8187_init_urbs(struct ieee80211_hw *dev)
> skb_queue_tail(&priv->rx_queue, skb);
> usb_anchor_urb(entry, &priv->anchored);
> ret = usb_submit_urb(entry, GFP_KERNEL);
> - usb_put_urb(entry);
> if (ret) {
> skb_unlink(skb, &priv->rx_queue);
> usb_unanchor_urb(entry);
> + usb_put_urb(entry);
> goto err;
> }
> + usb_put_urb(entry);
> }
> return ret;
Good catch.
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl818x: fix potential use after free
2018-11-29 10:48 [PATCH] rtl818x: fix potential use after free Pan Bian
2018-11-29 15:09 ` Larry Finger
@ 2018-12-13 15:03 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-12-13 15:03 UTC (permalink / raw)
To: Pan Bian
Cc: Herton Ronaldo Krzesinski, Hin-Tak Leung, Larry Finger,
David S. Miller, linux-wireless, netdev, linux-kernel, Pan Bian
Pan Bian <bianpan2016@163.com> wrote:
> entry is released via usb_put_urb just after calling usb_submit_urb.
> However, entry is used if the submission fails, resulting in a use after
> free bug. The patch fixes this.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
afbb1947db94 rtl818x: fix potential use after free
--
https://patchwork.kernel.org/patch/10704331/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-13 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 10:48 [PATCH] rtl818x: fix potential use after free Pan Bian
2018-11-29 15:09 ` Larry Finger
2018-12-13 15:03 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).