Linux-Wireless Archive on lore.kernel.org
 help / Atom feed
* [PATCH] staging: wilc1000: fix cast to restricted __le32
@ 2019-01-05  8:23 Július Milan
       [not found] ` <CAP=P++A1LritztQ1=fHOE7XXJN_0TvNHEjh7tVrpDj1kYFrNTQ@mail.gmail.com>
  2019-01-07 12:54 ` Dan Carpenter
  0 siblings, 2 replies; 5+ messages in thread
From: Július Milan @ 2019-01-05  8:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, linux-wireless, gregkh, ajay.kathat, adham.abozaeid

Fixes the following sparse warnings:

drivers/staging/wilc1000/host_interface.c:2360:30: warning:
 incorrect type in assignment (different base types)
    expected restricted __le32 [addressable] [assigned] [usertype] frame_type
    got restricted __le16 [usertype] <noident>

Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5dae6e7155d3..07c3d6293573 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2357,7 +2357,7 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg)
 	default:
 		break;
 	}
-	reg_frame.frame_type = cpu_to_le16(frame_type);
+	reg_frame.frame_type = cpu_to_le32(frame_type);
 	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
 				      wilc_get_vif_idx(vif));
 	if (result)
-- 
2.14.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: wilc1000: fix cast to restricted __le32
       [not found] ` <CAP=P++A1LritztQ1=fHOE7XXJN_0TvNHEjh7tVrpDj1kYFrNTQ@mail.gmail.com>
@ 2019-01-05  8:52   ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-01-05  8:52 UTC (permalink / raw)
  To: Július Milan
  Cc: Július Milan, linux-kernel, devel, linux-wireless,
	ajay.kathat, adham.abozaeid

On Sat, Jan 05, 2019 at 09:32:56AM +0100, Július Milan wrote:
> sorry, bad mail, see the next one please

Properly version your patches so I know what "next one" really means.

I've dropped all of these patches from my queue now, please resend with
a v2 added to the patch as the documentation says to do.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: wilc1000: fix cast to restricted __le32
  2019-01-05  8:23 [PATCH] staging: wilc1000: fix cast to restricted __le32 Július Milan
       [not found] ` <CAP=P++A1LritztQ1=fHOE7XXJN_0TvNHEjh7tVrpDj1kYFrNTQ@mail.gmail.com>
@ 2019-01-07 12:54 ` Dan Carpenter
  2019-01-07 13:23   ` Luc Van Oostenryck
  1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2019-01-07 12:54 UTC (permalink / raw)
  To: Július Milan, kbuild test robot
  Cc: linux-kernel, devel, gregkh, ajay.kathat, linux-wireless, adham.abozaeid

I'm sort of surprised that the zero day bot didn't complain about this.
It probably should.

The endianness checking is not turned on by default in Sparse.  You have
to do "make C=1 CF=-D__CHECK_ENDIAN__" to turn it on.

regards,
dan carpenter

On Sat, Jan 05, 2019 at 09:23:23AM +0100, Július Milan wrote:
> Fixes the following sparse warnings:
> 
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
>  incorrect type in assignment (different base types)
>     expected restricted __le32 [addressable] [assigned] [usertype] frame_type
>     got restricted __le16 [usertype] <noident>
> 
> Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
> Signed-off-by: Július Milan <jmilan.dev@gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 5dae6e7155d3..07c3d6293573 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2357,7 +2357,7 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg)
>  	default:
>  		break;
>  	}
> -	reg_frame.frame_type = cpu_to_le16(frame_type);
> +	reg_frame.frame_type = cpu_to_le32(frame_type);
>  	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
>  				      wilc_get_vif_idx(vif));
>  	if (result)
> -- 
> 2.14.5
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: wilc1000: fix cast to restricted __le32
  2019-01-07 12:54 ` Dan Carpenter
@ 2019-01-07 13:23   ` Luc Van Oostenryck
  0 siblings, 0 replies; 5+ messages in thread
From: Luc Van Oostenryck @ 2019-01-07 13:23 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Július Milan, kbuild test robot, linux-kernel, devel,
	gregkh, ajay.kathat, linux-wireless, adham.abozaeid

On Mon, Jan 07, 2019 at 03:54:37PM +0300, Dan Carpenter wrote:
> I'm sort of surprised that the zero day bot didn't complain about this.
> It probably should.
> 
> The endianness checking is not turned on by default in Sparse.  You have
> to do "make C=1 CF=-D__CHECK_ENDIAN__" to turn it on.

Bitwise (and thus endian) checking is enabled by default in the kernel
since 05de97003 ("linux/types.h: enable endian checks for all sparse builds")
included in v4.10-rc1. Since then they make more than half of sparse
warnings (in a x86-64 allyesconfig).

Best regards,
-- Luc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] staging: wilc1000: fix cast to restricted __le32
@ 2019-01-05  8:32 Július Milan
  0 siblings, 0 replies; 5+ messages in thread
From: Július Milan @ 2019-01-05  8:32 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, linux-wireless, gregkh, ajay.kathat, adham.abozaeid

Fixes the following sparse warnings:

drivers/staging/wilc1000/host_interface.c:2360:30: warning:
 incorrect type in assignment (different base types)
    expected restricted __le32 [addressable] [assigned] [usertype] frame_type
    got restricted __le16 [usertype] <noident>

Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5dae6e7155d3..07c3d6293573 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2357,7 +2357,7 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg)
 	default:
 		break;
 	}
-	reg_frame.frame_type = cpu_to_le16(frame_type);
+	reg_frame.frame_type = cpu_to_le32(frame_type);
 	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
 				      wilc_get_vif_idx(vif));
 	if (result)
-- 
2.14.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-05  8:23 [PATCH] staging: wilc1000: fix cast to restricted __le32 Július Milan
     [not found] ` <CAP=P++A1LritztQ1=fHOE7XXJN_0TvNHEjh7tVrpDj1kYFrNTQ@mail.gmail.com>
2019-01-05  8:52   ` Greg KH
2019-01-07 12:54 ` Dan Carpenter
2019-01-07 13:23   ` Luc Van Oostenryck
2019-01-05  8:32 Július Milan

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox