Re: [PATCH 1/2] brcmfmac: modify __brcmf_err() to take bus as a parameter

From: kbuild test robot <lkp@intel.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: kbuild-all@01.org, "Kalle Valo" <kvalo@codeaurora.org>,
	"Arend van Spriel" <arend.vanspriel@broadcom.com>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] brcmfmac: modify __brcmf_err() to take bus as a parameter
Date: Tue, 15 Jan 2019 19:42:59 +0800	[thread overview]
Message-ID: <201901151915.JmK2SYju%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190115061949.27260-1-zajec5@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2008 bytes --]

Hi Rafał,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v5.0-rc2 next-20190115]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-modify-__brcmf_err-to-take-bus-as-a-parameter/20190115-183015
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-randconfig-x006-201902 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c: In function '__brcmf_err':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:34:3: error: implicit declaration of function 'dev_err'; did you mean 'xa_err'? [-Werror=implicit-function-declaration]
      dev_err(bus->dev, "%s: %pV", func, &vaf);
      ^~~~~~~
      xa_err
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:34:14: error: dereferencing pointer to incomplete type 'struct brcmf_bus'
      dev_err(bus->dev, "%s: %pV", func, &vaf);
                 ^~
   cc1: some warnings being treated as errors

vim +34 drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c

    23	
    24	void __brcmf_err(struct brcmf_bus *bus, const char *func, const char *fmt, ...)
    25	{
    26		struct va_format vaf = {
    27			.fmt = fmt,
    28		};
    29		va_list args;
    30	
    31		va_start(args, fmt);
    32		vaf.va = &args;
    33		if (bus)
  > 34			dev_err(bus->dev, "%s: %pV", func, &vaf);
    35		else
    36			pr_err("%s: %pV", func, &vaf);
    37		trace_brcmf_err(func, &vaf);
    38		va_end(args);
    39	}
    40	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34794 bytes --]