Re: [PATCH 2/2] brcmfmac: pass bus to the __brcmf_err() in cfg80211.c

From: kbuild test robot <lkp@intel.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: kbuild-all@01.org, "Kalle Valo" <kvalo@codeaurora.org>,
	"Arend van Spriel" <arend.vanspriel@broadcom.com>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 2/2] brcmfmac: pass bus to the __brcmf_err() in cfg80211.c
Date: Tue, 15 Jan 2019 19:09:00 +0800	[thread overview]
Message-ID: <201901151922.FUQVKshr%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190115062056.27384-1-zajec5@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2767 bytes --]

Hi Rafał,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v5.0-rc2 next-20190115]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-modify-__brcmf_err-to-take-bus-as-a-parameter/20190115-183015
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-randconfig-x071-201902 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function 'brcmf_cfg80211_set_rekey_data':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5205:13: error: 'bus' undeclared (first use in this function)
      brcmf_err(bus, "gtk_key_info iovar failed: ret=%d\n", ret);
                ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:32:16: note: in definition of macro 'brcmf_err'
       __brcmf_err(bus, __func__, fmt, ##__VA_ARGS__); \
                   ^~~
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5205:13: note: each undeclared identifier is reported only once for each function it appears in
      brcmf_err(bus, "gtk_key_info iovar failed: ret=%d\n", ret);
                ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:32:16: note: in definition of macro 'brcmf_err'
       __brcmf_err(bus, __func__, fmt, ##__VA_ARGS__); \
                   ^~~

vim +/bus +5205 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

  5185	
  5186	#ifdef CONFIG_PM
  5187	static int
  5188	brcmf_cfg80211_set_rekey_data(struct wiphy *wiphy, struct net_device *ndev,
  5189				      struct cfg80211_gtk_rekey_data *gtk)
  5190	{
  5191		struct brcmf_if *ifp = netdev_priv(ndev);
  5192		struct brcmf_gtk_keyinfo_le gtk_le;
  5193		int ret;
  5194	
  5195		brcmf_dbg(TRACE, "Enter, bssidx=%d\n", ifp->bsscfgidx);
  5196	
  5197		memcpy(gtk_le.kck, gtk->kck, sizeof(gtk_le.kck));
  5198		memcpy(gtk_le.kek, gtk->kek, sizeof(gtk_le.kek));
  5199		memcpy(gtk_le.replay_counter, gtk->replay_ctr,
  5200		       sizeof(gtk_le.replay_counter));
  5201	
  5202		ret = brcmf_fil_iovar_data_set(ifp, "gtk_key_info", &gtk_le,
  5203					       sizeof(gtk_le));
  5204		if (ret < 0)
> 5205			brcmf_err(bus, "gtk_key_info iovar failed: ret=%d\n", ret);
  5206	
  5207		return ret;
  5208	}
  5209	#endif
  5210	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33233 bytes --]