* pull-request: iwlwifi-next 2019-01-29
@ 2019-01-29 14:19 Luca Coelho
2019-01-30 11:09 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Luca Coelho @ 2019-01-29 14:19 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, linuxwifi, david.e.box, joe.konno
[-- Attachment #1: Type: text/plain, Size: 7587 bytes --]
Hi Kalle,
This is the second batch of patches intended for v5.1. This includes
the last two patchsets I sent. Usual development work. More details
about the contents in the tag description.
I have sent this out before and kbuildbot reported success.
Please let me know if there are any issues.
Cheers,
Luca.
The following changes since commit 64e2330580fbbfa7077ef2f608555f07e0bb4956:
Merge tag 'iwlwifi-next-for-kalle-2019-01-25' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next (2019-01-29 14:56:05 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-kalle-2019-01-29
for you to fetch changes up to 01f377dc927da6e42cbffb00fc8d431c8341da3f:
iwiwifi: fix bad monitor buffer register addresses (2019-01-29 16:10:33 +0200)
----------------------------------------------------------------
Second batch of iwlwifi patches intended for v5.1
* A bunch of fixes for issues found with static analyzers;
* Relicense the pcie submodule to dual GPL/BSD;
* Reworked the TOF/CSI implementation;
* Work on new debugging infra continues;
* Some product name updates in the human-readable strings
* Some more cleanups for the device configuration refactoring;
* General bugfixes;
* Other cleanups and small fixes;
----------------------------------------------------------------
Andrei Otcheretianski (1):
iwlwifi: mvm: Disconnect on large beacon loss
David Spinadel (1):
iwlwifi: mvm: Change FW channel info API
Emmanuel Grumbach (1):
iwlwifi: mvm: freeze management TXQ timer when station goes to sleep
Ihab Zhaika (1):
iwlwifi: update product name for 9260 and 9560
Johannes Berg (13):
iwlwifi: mvm: fix %16 to %016 print format
iwlwifi: mvm: read IWL_RX_MPDU_PHY_SHORT_PREAMBLE only for CCK
iwlwifi: pcie: align licensing to dual GPL/BSD
iwlwifi: mvm: clean up LDBG config command usage
iwlwifi: move iwl_enable_{rx,tx}_ampdu to iwl-modparams.h
iwlwifi: mvm: fix A-MPDU reference assignment
iwlwifi: remove TOF implementation
iwlwifi: dvm: remove useless condition
iwlwifi: pcie: use u32* argument to iwl_trans_get_fw_monitor_len()
iwlwifi: mvm: add location APIs
iwlwifi: mvm: implement CSI reporting
iwlwifi: mvm: document monitor mode reorder buffer bypass
iwlwifi: mvm: include configured sniffer AID in radiotap
Liad Kaufman (1):
iwlwifi: mvm: remove sta key on wep ap
Luca Coelho (5):
iwlwifi: mvm: save and export regdb blob from the NVM
iwlwifi: make iwl_fw_dbg_start_stop_hcmd() inline
iwlwifi: mvm: pre-initialize alive_data in wait_alive()
iwlwifi: calculate pointers from out_cmd instead of out_cmd->hdr
iwlwifi: make sure cur_fw_img is valid before accessing img
Mordechay Goodstein (1):
iwlwifi: mvm: disable completely low latency mode with debugfs
Sara Sharon (4):
iwlwifi: pcie: fix the use of a wrong define
iwlwifi: pcie: add prints to track virtual ID
iwlwifi: mvm: add an option to dereference vif by id
iwlwifi: mvm: get rid of tx_path_lock
Shahar S Matityahu (7):
iwlwifi: monitor dumping flow cleanup
iwlwifi: trigger dump on assert prior to setting the device up
iwlwifi: dbg_ini: allocate dram buffer with proper flags
iwlwifi: dbg_ini: properly handle ini user trigger
iwlwifi: dbg_ini: retrieve dump_delay value properly
iwlwifi: dbg_ini: set dump mask BIT(n) instead of n
iwiwifi: fix bad monitor buffer register addresses
Shaul Triebitz (3):
iwlwifi: iwlmvm: ignore HE PPDU type regarding EOF
iwlwifi: iwlmvm: in monitor NDP notif take the NSS from rx_vec
iwlwifi: mvm: update firmware when MU EDCA params change
drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 6 +
drivers/net/wireless/intel/iwlwifi/cfg/9000.c | 29 ++++
drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c | 23 +--
drivers/net/wireless/intel/iwlwifi/dvm/tt.c | 5 +-
drivers/net/wireless/intel/iwlwifi/fw/api/commands.h | 15 +-
drivers/net/wireless/intel/iwlwifi/fw/api/datapath.h | 55 +++++++
drivers/net/wireless/intel/iwlwifi/fw/api/debug.h | 33 ++--
drivers/net/wireless/intel/iwlwifi/fw/api/location.h | 711 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
drivers/net/wireless/intel/iwlwifi/fw/api/phy-ctxt.h | 51 ++++--
drivers/net/wireless/intel/iwlwifi/fw/api/rx.h | 7 +-
drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h | 19 ++-
drivers/net/wireless/intel/iwlwifi/fw/api/time-event.h | 34 ++--
drivers/net/wireless/intel/iwlwifi/fw/api/tof.h | 393 ----------------------------------------------
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 28 ++--
drivers/net/wireless/intel/iwlwifi/fw/dbg.h | 17 +-
drivers/net/wireless/intel/iwlwifi/fw/file.h | 12 +-
drivers/net/wireless/intel/iwlwifi/iwl-config.h | 5 +
drivers/net/wireless/intel/iwlwifi/iwl-io.c | 41 ++++-
drivers/net/wireless/intel/iwlwifi/iwl-io.h | 38 ++++-
drivers/net/wireless/intel/iwlwifi/iwl-modparams.h | 18 +++
drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 4 +-
drivers/net/wireless/intel/iwlwifi/mvm/Makefile | 1 -
drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c | 813 ++++++-----------------------------------------------------------------------------------------
drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 91 +++++------
drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 4 +-
drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 104 ++++++-------
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 124 +++++++++------
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 150 ++++++++++++++++--
drivers/net/wireless/intel/iwlwifi/mvm/nvm.c | 5 +
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 29 +++-
drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c | 24 ++-
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 101 ++++++++----
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 4 +-
drivers/net/wireless/intel/iwlwifi/mvm/tdls.c | 33 ++--
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c | 4 +-
drivers/net/wireless/intel/iwlwifi/mvm/tof.c | 305 ------------------------------------
drivers/net/wireless/intel/iwlwifi/mvm/tof.h | 89 -----------
drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 24 ++-
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 188 +++++++++++-----------
drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 44 +++++-
drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 52 ++++++-
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 20 +--
drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 6 +-
drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 44 +++++-
45 files changed, 1759 insertions(+), 2046 deletions(-)
create mode 100644 drivers/net/wireless/intel/iwlwifi/fw/api/location.h
delete mode 100644 drivers/net/wireless/intel/iwlwifi/fw/api/tof.h
delete mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/tof.c
delete mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/tof.h
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: pull-request: iwlwifi-next 2019-01-29
2019-01-29 14:19 pull-request: iwlwifi-next 2019-01-29 Luca Coelho
@ 2019-01-30 11:09 ` Kalle Valo
2019-01-30 11:50 ` Luca Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-01-30 11:09 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless, linuxwifi, david.e.box, joe.konno
Luca Coelho <luca@coelho.fi> writes:
> This is the second batch of patches intended for v5.1. This includes
> the last two patchsets I sent. Usual development work. More details
> about the contents in the tag description.
>
> I have sent this out before and kbuildbot reported success.
>
> Please let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 64e2330580fbbfa7077ef2f608555f07e0bb4956:
>
> Merge tag 'iwlwifi-next-for-kalle-2019-01-25' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next (2019-01-29 14:56:05 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-kalle-2019-01-29
>
> for you to fetch changes up to 01f377dc927da6e42cbffb00fc8d431c8341da3f:
>
> iwiwifi: fix bad monitor buffer register addresses (2019-01-29 16:10:33 +0200)
>
> ----------------------------------------------------------------
> Second batch of iwlwifi patches intended for v5.1
>
> * A bunch of fixes for issues found with static analyzers;
> * Relicense the pcie submodule to dual GPL/BSD;
> * Reworked the TOF/CSI implementation;
> * Work on new debugging infra continues;
> * Some product name updates in the human-readable strings
> * Some more cleanups for the device configuration refactoring;
> * General bugfixes;
> * Other cleanups and small fixes;
>
> ----------------------------------------------------------------
Pulled, thanks.
Oh, but I see a new warning:
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:195:13: warning: 'iwl_mvm_add_rtap_sniffer_config' defined but not used [-Wunused-function]
static void iwl_mvm_add_rtap_sniffer_config(struct iwl_mvm *mvm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Can you send separately a patch to fix this so that I can apply it
directly?
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: pull-request: iwlwifi-next 2019-01-29
2019-01-30 11:09 ` Kalle Valo
@ 2019-01-30 11:50 ` Luca Coelho
2019-01-30 12:38 ` [PATCH] iwlwifi: mvm: fix merge damage in iwl_mvm_rx_mpdu_mq() Luca Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Luca Coelho @ 2019-01-30 11:50 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, linuxwifi, david.e.box, joe.konno
On Wed, 2019-01-30 at 13:09 +0200, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
>
> > This is the second batch of patches intended for v5.1. This
> > includes
> > the last two patchsets I sent. Usual development work. More
> > details
> > about the contents in the tag description.
> >
> > I have sent this out before and kbuildbot reported success.
> >
> > Please let me know if there are any issues.
> >
> > Cheers,
> > Luca.
> >
> >
> > The following changes since commit
> > 64e2330580fbbfa7077ef2f608555f07e0bb4956:
> >
> > Merge tag 'iwlwifi-next-for-kalle-2019-01-25' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next
> > (2019-01-29 14:56:05 +0200)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-
> > next.git tags/iwlwifi-next-for-kalle-2019-01-29
> >
> > for you to fetch changes up to
> > 01f377dc927da6e42cbffb00fc8d431c8341da3f:
> >
> > iwiwifi: fix bad monitor buffer register addresses (2019-01-29
> > 16:10:33 +0200)
> >
> > ----------------------------------------------------------------
> > Second batch of iwlwifi patches intended for v5.1
> >
> > * A bunch of fixes for issues found with static analyzers;
> > * Relicense the pcie submodule to dual GPL/BSD;
> > * Reworked the TOF/CSI implementation;
> > * Work on new debugging infra continues;
> > * Some product name updates in the human-readable strings
> > * Some more cleanups for the device configuration refactoring;
> > * General bugfixes;
> > * Other cleanups and small fixes;
> >
> > ----------------------------------------------------------------
>
> Pulled, thanks.
>
> Oh, but I see a new warning:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:195:13: warning:
> 'iwl_mvm_add_rtap_sniffer_config' defined but not used [-Wunused-
> function]
> static void iwl_mvm_add_rtap_sniffer_config(struct iwl_mvm *mvm,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Can you send separately a patch to fix this so that I can apply it
> directly?
Ugh, I broke something when resolving conflicts. I'll send a fix asap.
--
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] iwlwifi: mvm: fix merge damage in iwl_mvm_rx_mpdu_mq()
2019-01-30 11:50 ` Luca Coelho
@ 2019-01-30 12:38 ` Luca Coelho
2019-01-31 13:34 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Luca Coelho @ 2019-01-30 12:38 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Luca Coelho
From: Luca Coelho <luciano.coelho@intel.com>
A call to iwl_mvm_add_rtap_sniffer_config() was missing due to a merge
damage when I submitted the patch mentioned below. And this causes
the following compilation warning:
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:195:13: warning: 'iwl_mvm_add_rtap_sniffer_config' defined but not used [-Wunused-function]
static void iwl_mvm_add_rtap_sniffer_config(struct iwl_mvm *mvm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix it by adding the if block that calls this function.
Fixes: 9bf13bee2d74 ("iwlwifi: mvm: include configured sniffer AID in radiotap")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
index 995847e1cd7d..b5ff3325c1d3 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
@@ -1476,6 +1476,9 @@ void iwl_mvm_rx_mpdu_mq(struct iwl_mvm *mvm, struct napi_struct *napi,
rx_status->ampdu_reference = mvm->ampdu_ref;
}
+ if (unlikely(mvm->monitor_on))
+ iwl_mvm_add_rtap_sniffer_config(mvm, skb);
+
rcu_read_lock();
if (desc->status & cpu_to_le16(IWL_RX_MPDU_STATUS_SRC_STA_FOUND)) {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-31 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 14:19 pull-request: iwlwifi-next 2019-01-29 Luca Coelho
2019-01-30 11:09 ` Kalle Valo
2019-01-30 11:50 ` Luca Coelho
2019-01-30 12:38 ` [PATCH] iwlwifi: mvm: fix merge damage in iwl_mvm_rx_mpdu_mq() Luca Coelho
2019-01-31 13:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).