From: Joerg Roedel <joro@8bytes.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Rosen Penev <rosenp@gmail.com>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Samuel Sieb <samuel@sieb.net>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, jan.viktorin@gmail.com
Subject: Re: [PATCH v2] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE
Date: Mon, 18 Mar 2019 11:17:03 +0100 [thread overview]
Message-ID: <20190318101703.GA6100@8bytes.org> (raw)
In-Reply-To: <20190313090316.GA2663@redhat.com>
Hi Stanislaw,
thanks a lot for looking into this and tracking it down!
On Wed, Mar 13, 2019 at 10:03:17AM +0100, Stanislaw Gruszka wrote:
> - s->dma_address += address + s->offset;
> + /* Add in the remaining piece of the scatter-gather offset that
> + * was masked out when we were determining the physical address
> + * via (sg_phys(s) & PAGE_MASK) earlier.
> + */
> + s->dma_address += address + (s->offset & ~PAGE_MASK);
> s->dma_length = s->length;
Applied the patch for v5.1 (with an added Fixes-tag and a minor coding
style change) and will send it upstream soon.
Thanks again,
Joerg
next prev parent reply other threads:[~2019-03-18 10:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 22:55 MT76x2U crashes XHCI driver on AMD Ryzen system Rosen Penev
2019-01-11 17:29 ` Lorenzo Bianconi
2019-01-11 19:01 ` Rosen Penev
2019-01-13 13:33 ` Lorenzo Bianconi
[not found] ` <1547404075.1582.0@smtp.gmail.com>
2019-01-13 19:00 ` Lorenzo Bianconi
2019-01-14 2:20 ` Rosen Penev
2019-01-14 3:13 ` Samuel Sieb
2019-01-14 9:18 ` Lorenzo Bianconi
2019-01-14 9:22 ` Tom Psyborg
2019-01-14 20:06 ` Rosen Penev
2019-01-15 9:04 ` Lorenzo Bianconi
2019-02-18 14:37 ` Stanislaw Gruszka
2019-02-18 15:15 ` Lorenzo Bianconi
2019-02-18 17:01 ` Robin Murphy
2019-02-19 11:08 ` Stanislaw Gruszka
2019-02-26 10:05 ` Joerg Roedel
2019-02-26 10:34 ` Stanislaw Gruszka
2019-02-26 10:44 ` Joerg Roedel
2019-02-26 11:24 ` Stanislaw Gruszka
2019-02-28 9:04 ` Stanislaw Gruszka
2019-02-28 10:42 ` Stanislaw Gruszka
2019-02-28 12:19 ` Stanislaw Gruszka
2019-02-28 13:40 ` Joerg Roedel
2019-03-04 7:10 ` Stanislaw Gruszka
2019-03-04 7:20 ` Rosen Penev
2019-03-11 8:43 ` Stanislaw Gruszka
2019-03-11 9:03 ` [PATCH] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE Stanislaw Gruszka
2019-03-11 15:47 ` Alexander Duyck
2019-03-12 7:08 ` Stanislaw Gruszka
2019-03-12 15:18 ` Alexander Duyck
2019-03-13 9:03 ` [PATCH v2] " Stanislaw Gruszka
2019-03-18 10:17 ` Joerg Roedel [this message]
2019-03-12 7:13 ` MT76x2U crashes XHCI driver on AMD Ryzen system Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318101703.GA6100@8bytes.org \
--to=joro@8bytes.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jan.viktorin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=rosenp@gmail.com \
--cc=samuel@sieb.net \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).