* [PATCH] mt7601u: use params->ssn value directly
@ 2019-07-12 12:09 Stanislaw Gruszka
2019-07-12 17:35 ` Jakub Kicinski
2019-07-24 11:52 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2019-07-12 12:09 UTC (permalink / raw)
To: linux-wireless; +Cc: Jakub Kicinski
There is no point to use pointer to params->ssn.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/mediatek/mt7601u/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/main.c b/drivers/net/wireless/mediatek/mt7601u/main.c
index 89a7b1234ffb..72e608cc53af 100644
--- a/drivers/net/wireless/mediatek/mt7601u/main.c
+++ b/drivers/net/wireless/mediatek/mt7601u/main.c
@@ -351,7 +351,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
struct ieee80211_sta *sta = params->sta;
enum ieee80211_ampdu_mlme_action action = params->action;
u16 tid = params->tid;
- u16 *ssn = ¶ms->ssn;
+ u16 ssn = params->ssn;
struct mt76_sta *msta = (struct mt76_sta *) sta->drv_priv;
WARN_ON(msta->wcid.idx > GROUP_WCID(0));
@@ -371,7 +371,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT:
break;
case IEEE80211_AMPDU_TX_START:
- msta->agg_ssn[tid] = *ssn << 4;
+ msta->agg_ssn[tid] = ssn << 4;
ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
break;
case IEEE80211_AMPDU_TX_STOP_CONT:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: use params->ssn value directly
2019-07-12 12:09 [PATCH] mt7601u: use params->ssn value directly Stanislaw Gruszka
@ 2019-07-12 17:35 ` Jakub Kicinski
2019-07-24 11:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-07-12 17:35 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless
On Fri, 12 Jul 2019 14:09:50 +0200, Stanislaw Gruszka wrote:
> There is no point to use pointer to params->ssn.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: use params->ssn value directly
2019-07-12 12:09 [PATCH] mt7601u: use params->ssn value directly Stanislaw Gruszka
2019-07-12 17:35 ` Jakub Kicinski
@ 2019-07-24 11:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-07-24 11:52 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless, Jakub Kicinski
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> There is no point to use pointer to params->ssn.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
f0248ec49bde mt7601u: use params->ssn value directly
--
https://patchwork.kernel.org/patch/11042213/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12 12:09 [PATCH] mt7601u: use params->ssn value directly Stanislaw Gruszka
2019-07-12 17:35 ` Jakub Kicinski
2019-07-24 11:52 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).