* [PATCH] bcma: remove two unused variables
@ 2019-08-09 8:53 YueHaibing
2019-09-03 13:38 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-09 8:53 UTC (permalink / raw)
To: zajec5, kvalo; +Cc: linux-kernel, linux-wireless, YueHaibing
drivers/bcma/driver_mips.c:70:18: warning:
ipsflag_irq_shift defined but not used [-Wunused-const-variable=]
drivers/bcma/driver_mips.c:62:18: warning:
ipsflag_irq_mask defined but not used [-Wunused-const-variable=]
They are never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/bcma/driver_mips.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
index 27e9686..87760aa 100644
--- a/drivers/bcma/driver_mips.c
+++ b/drivers/bcma/driver_mips.c
@@ -59,22 +59,6 @@ static inline void mips_write32(struct bcma_drv_mips *mcore,
bcma_write32(mcore->core, offset, value);
}
-static const u32 ipsflag_irq_mask[] = {
- 0,
- BCMA_MIPS_IPSFLAG_IRQ1,
- BCMA_MIPS_IPSFLAG_IRQ2,
- BCMA_MIPS_IPSFLAG_IRQ3,
- BCMA_MIPS_IPSFLAG_IRQ4,
-};
-
-static const u32 ipsflag_irq_shift[] = {
- 0,
- BCMA_MIPS_IPSFLAG_IRQ1_SHIFT,
- BCMA_MIPS_IPSFLAG_IRQ2_SHIFT,
- BCMA_MIPS_IPSFLAG_IRQ3_SHIFT,
- BCMA_MIPS_IPSFLAG_IRQ4_SHIFT,
-};
-
static u32 bcma_core_mips_irqflag(struct bcma_device *dev)
{
u32 flag;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcma: remove two unused variables
2019-08-09 8:53 [PATCH] bcma: remove two unused variables YueHaibing
@ 2019-09-03 13:38 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-09-03 13:38 UTC (permalink / raw)
To: YueHaibing; +Cc: zajec5, linux-kernel, linux-wireless, YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> drivers/bcma/driver_mips.c:70:18: warning:
> ipsflag_irq_shift defined but not used [-Wunused-const-variable=]
> drivers/bcma/driver_mips.c:62:18: warning:
> ipsflag_irq_mask defined but not used [-Wunused-const-variable=]
>
> They are never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
0a60e0aa495f bcma: remove two unused variables
--
https://patchwork.kernel.org/patch/11085683/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 8:53 [PATCH] bcma: remove two unused variables YueHaibing
2019-09-03 13:38 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).