* [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear()
@ 2019-08-13 12:04 Oliver Neukum
2019-09-03 13:39 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2019-08-13 12:04 UTC (permalink / raw)
To: davem, netdev, dsd, kune, kvalo, linux-wireless; +Cc: Oliver Neukum
The function is called before the lock which is asserted was ever used.
Just remove it.
V2: correct CCs
V3: correct name
Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
index da7e63fca9f5..a9999d10ae81 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
@@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
{
flush_workqueue(zd_workqueue);
zd_chip_clear(&mac->chip);
- lockdep_assert_held(&mac->lock);
ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
}
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear()
2019-08-13 12:04 [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear() Oliver Neukum
@ 2019-09-03 13:39 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-09-03 13:39 UTC (permalink / raw)
To: Oliver Neukum; +Cc: davem, netdev, dsd, kune, linux-wireless, Oliver Neukum
Oliver Neukum <oneukum@suse.com> wrote:
> The function is called before the lock which is asserted was ever used.
> Just remove it.
>
> Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Patch applied to wireless-drivers-next.git, thanks.
7a2eb7367fde zd1211rw: remove false assertion from zd_mac_clear()
--
https://patchwork.kernel.org/patch/11092009/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 12:04 [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear() Oliver Neukum
2019-09-03 13:39 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).