From: "Michael Büsch" <m@bues.ch>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Colin King <colin.king@canonical.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller
Date: Mon, 9 Sep 2019 19:53:12 +0200 [thread overview]
Message-ID: <20190909195312.1873c0f7@wiggum> (raw)
In-Reply-To: <20190906154053.32218-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Fri, 6 Sep 2019 16:40:53 +0100
Colin King <colin.king@canonical.com> wrote:
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index da2d2ab8104d..7c3ae52f2b15 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
> {
> int i;
> u16 o;
> - u16 pwr_info_offset[] = {
> + static const u16 pwr_info_offset[] = {
> SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
> SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
> };
Thanks for your contribution. This change makes sense.
Kalle, can you please take it?
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-09 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:40 [PATCH] ssb: make array pwr_info_offset static const, makes object smaller Colin King
2019-09-09 17:53 ` Michael Büsch [this message]
2019-09-13 14:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909195312.1873c0f7@wiggum \
--to=m@bues.ch \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).