* [PATCH] rt2x00: initialize last_reset
@ 2019-09-26 8:54 Stanislaw Gruszka
2019-10-01 9:09 ` Kalle Valo
2019-10-02 4:37 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2019-09-26 8:54 UTC (permalink / raw)
To: linux-wireless
Cc: Tomislav Požega, Daniel Golle, Felix Fietkau,
Mathias Kresin, Jonathan Liu
Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
possible to test H/W reset for first 5 minutes of system run.
Fixes: e403fa31ed71 ("rt2x00: add restart hw")
Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/ralink/rt2x00/rt2x00debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
index 4d4e3888ef20..f2395309ec00 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
@@ -555,7 +555,7 @@ static ssize_t rt2x00debug_write_restart_hw(struct file *file,
{
struct rt2x00debug_intf *intf = file->private_data;
struct rt2x00_dev *rt2x00dev = intf->rt2x00dev;
- static unsigned long last_reset;
+ static unsigned long last_reset = INITIAL_JIFFIES;
if (!rt2x00_has_cap_restart_hw(rt2x00dev))
return -EOPNOTSUPP;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rt2x00: initialize last_reset
2019-09-26 8:54 [PATCH] rt2x00: initialize last_reset Stanislaw Gruszka
@ 2019-10-01 9:09 ` Kalle Valo
2019-10-02 4:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-10-01 9:09 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless, Tomislav Požega, Daniel Golle,
Felix Fietkau, Mathias Kresin, Jonathan Liu
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
>
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
I'll queue this to v5.4.
--
https://patchwork.kernel.org/patch/11161981/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rt2x00: initialize last_reset
2019-09-26 8:54 [PATCH] rt2x00: initialize last_reset Stanislaw Gruszka
2019-10-01 9:09 ` Kalle Valo
@ 2019-10-02 4:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-10-02 4:37 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless, Tomislav Požega, Daniel Golle,
Felix Fietkau, Mathias Kresin, Jonathan Liu
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
>
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers.git, thanks.
c91a9cfe9f6d rt2x00: initialize last_reset
--
https://patchwork.kernel.org/patch/11161981/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-02 4:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 8:54 [PATCH] rt2x00: initialize last_reset Stanislaw Gruszka
2019-10-01 9:09 ` Kalle Valo
2019-10-02 4:37 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).